From owner-freebsd-current@FreeBSD.ORG Wed May 7 15:29:18 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DB6FD37B401; Wed, 7 May 2003 15:29:18 -0700 (PDT) Received: from beastie.mckusick.com (p35.n-sfpop02.stsn.com [199.107.153.35]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5A29043FCB; Wed, 7 May 2003 15:29:17 -0700 (PDT) (envelope-from mckusick@beastie.mckusick.com) Received: from beastie.mckusick.com (localhost [127.0.0.1]) by beastie.mckusick.com (8.12.8/8.12.3) with ESMTP id h47MTDTh024656; Wed, 7 May 2003 15:29:14 -0700 (PDT) (envelope-from mckusick@beastie.mckusick.com) Message-Id: <200305072229.h47MTDTh024656@beastie.mckusick.com> To: Lukas Ertl X-URL: http://WWW.McKusick.COM/ Date: Wed, 07 May 2003 15:29:13 -0700 From: Kirk McKusick cc: DougB@freebsd.org cc: freebsd-current@freebsd.org Subject: bin/51619 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Kirk McKusick List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 May 2003 22:29:19 -0000 At one time I had the suggested change that you made in bin/51619 in the FreeBSD-5.0 newfs program. The problem with that change is that the bootstrap on some architectures now exceeds 8K which means that instead of zeroing an old superblock you destroy the boot code. So, I removed the zeroing of the old UFS1 superblock area. A possible alternative would be to check for a UFS1 magic number at the old location (and also at the 16K first backup location) and zero out just those fields if they are found. While it is possible that a bootstrap might just have that number at that offset, it is highly unlikely. Kirk McKusick