From owner-svn-src-head@freebsd.org  Fri Feb 17 16:51:52 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id EDADCCE3657;
 Fri, 17 Feb 2017 16:51:52 +0000 (UTC)
 (envelope-from vangyzen@FreeBSD.org)
Received: from smtp.vangyzen.net (hotblack.vangyzen.net [199.48.133.146])
 by mx1.freebsd.org (Postfix) with ESMTP id D646215B1;
 Fri, 17 Feb 2017 16:51:52 +0000 (UTC)
 (envelope-from vangyzen@FreeBSD.org)
Received: from ford.home.vangyzen.net (unknown [76.164.15.242])
 by smtp.vangyzen.net (Postfix) with ESMTPSA id B0C4A56486;
 Fri, 17 Feb 2017 10:51:45 -0600 (CST)
Subject: Re: svn commit: r313821 - in head/sys: dev/cxgb/ulp/iw_cxgb
 fs/nfsserver kern netinet netinet/libalias netpfil/ipfw
To: Gleb Smirnoff <glebius@FreeBSD.org>
References: <201702162047.v1GKlf9j014479@repo.freebsd.org>
 <20170217041748.GI58829@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
From: Eric van Gyzen <vangyzen@FreeBSD.org>
Message-ID: <c8e82548-f8ae-23c0-4bbf-1ac2f2ebb5bb@FreeBSD.org>
Date: Fri, 17 Feb 2017 10:51:40 -0600
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101
 Thunderbird/45.6.0
MIME-Version: 1.0
In-Reply-To: <20170217041748.GI58829@FreeBSD.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Feb 2017 16:51:53 -0000

On 02/16/2017 22:17, Gleb Smirnoff wrote:
>   Eric,
>
>   heh, things are worse. Multiple places you changes are CTR()
> macros. Neither inet_ntoa() nor inet_ntoa_r() will work with
> them. :(
>
> Basicly non-constant strings can not be logged with KTR. All
> the lines you touched should log actual binary value of the
> IPv4 address.

*facepalm*  It's even worse, because I /knew/ about this, but I failed to think 
of it while making this change.  Oh well.

> I am not asking you to do this work! :) But I couldn't leave
> that without a comment.

:)  Thanks for mentioning it.

Eric