From owner-freebsd-ports@FreeBSD.ORG Mon Oct 1 20:07:41 2007 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 04EB516A420 for ; Mon, 1 Oct 2007 20:07:41 +0000 (UTC) (envelope-from uspoerlein@gmail.com) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.170]) by mx1.freebsd.org (Postfix) with ESMTP id 97C9A13C4A7 for ; Mon, 1 Oct 2007 20:07:40 +0000 (UTC) (envelope-from uspoerlein@gmail.com) Received: by ug-out-1314.google.com with SMTP id a2so2294913ugf for ; Mon, 01 Oct 2007 13:07:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:received:received:date:from:to:cc:subject:message-id:mail-followup-to:mime-version:content-type:content-disposition:user-agent; bh=HUfd2NEzsVVvU8V5NrL1ExxZN7xHryMqD+si6w6Y3uc=; b=oo2Wnw6Ba5TkIClN8a788xPNSqdzV1f2iESpp9XaWEoX5gk+E8dnzh6aHUm3GDjc+FReRosnKlQhwVxg8EKfff0iCRI5DWFmFQnM41PS+SxuXffRVPt8tP3FitYDGS/KiXZhtIgOlRCWS7yWgkRNMGnV+dF9cxpm+PH+Ie75btU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:date:from:to:cc:subject:message-id:mail-followup-to:mime-version:content-type:content-disposition:user-agent; b=MIVBWZYj+lK7VtLAiD/nYldeG45ENs7IvkKgYN0Z3UX1eKwFM6EvCKP19CQJ0Gs2T0V82ol1a0Y+sNsOVbbmGni+PP4/kegA60So7GeQ8WuxRAbm8FH6yCHJg0gJfmhsiMnpNzhmBFsIIgcRhtLpcUj4Rntry+tcKbDcVyn2U4k= Received: by 10.66.221.5 with SMTP id t5mr9275798ugg.1191267639927; Mon, 01 Oct 2007 12:40:39 -0700 (PDT) Received: from roadrunner.spoerlein.net ( [85.180.139.26]) by mx.google.com with ESMTPS id u7sm4248uge.2007.10.01.12.40.39 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 01 Oct 2007 12:40:39 -0700 (PDT) Received: from roadrunner.spoerlein.net (localhost [127.0.0.1]) by roadrunner.spoerlein.net (8.14.1/8.14.1) with ESMTP id l91JeZZg006663; Mon, 1 Oct 2007 21:40:35 +0200 (CEST) (envelope-from uspoerlein@gmail.com) Received: (from q@localhost) by roadrunner.spoerlein.net (8.14.1/8.14.1/Submit) id l91JeZda006662; Mon, 1 Oct 2007 21:40:35 +0200 (CEST) (envelope-from uspoerlein@gmail.com) Date: Mon, 1 Oct 2007 21:40:35 +0200 From: Ulrich Spoerlein To: thompsa@freebsd.org Message-ID: <20071001194035.GA1462@roadrunner.spoerlein.net> Mail-Followup-To: thompsa@freebsd.org, ports@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.16 (2007-06-09) Cc: ports@freebsd.org Subject: struct wi_req: how to deal with removal, affects multiple ports X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2007 20:07:41 -0000 Hi, on July 11th you removed the definition for struct wi_req on -CURRENT from sys/dev/wi/if_wavelan_ieee.h with the following commit message revision 1.21 date: 2007/07/11 21:25:48; author: thompsa; state: Exp; lines: +2 -0 Now that wicontrol has been removed from the base system the corresponding ioctls can be removed. These have been #ifdef'd out and left as a reference in case any of the RIDs need to be turned into sysctls at a later date. Reviewed by: sam, avatar Approved by: re (kensmith) I don't know why, but recently at least the ports xwlans and wmwifi fail to build because of the missing definition, I guess. bsd-airtools has recently been flagged as broken, too. Presumably due to the same reason. How should these ports deal with this? Both are calling SIOCGWAVELAN with wi_type set to WI_RID_COMMS_QUALITY. Cheers, Ulrich Spoerlein -- It is better to remain silent and be thought a fool, than to speak, and remove all doubt.