From owner-freebsd-current@FreeBSD.ORG Mon Feb 27 13:59:39 2006 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9168216A420 for ; Mon, 27 Feb 2006 13:59:39 +0000 (GMT) (envelope-from dwmalone@maths.tcd.ie) Received: from salmon.maths.tcd.ie (salmon.maths.tcd.ie [134.226.81.11]) by mx1.FreeBSD.org (Postfix) with SMTP id CEBC243D45 for ; Mon, 27 Feb 2006 13:59:38 +0000 (GMT) (envelope-from dwmalone@maths.tcd.ie) Received: from walton.maths.tcd.ie ([134.226.81.10] helo=walton.maths.tcd.ie) by salmon.maths.tcd.ie with SMTP id ; 27 Feb 2006 13:59:37 +0000 (GMT) Date: Mon, 27 Feb 2006 13:59:36 +0000 From: David Malone To: Rohit Jalan Message-ID: <20060227135936.GA39098@walton.maths.tcd.ie> References: <20060227105753.GA6726@desk01.n2.purpe.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060227105753.GA6726@desk01.n2.purpe.com> User-Agent: Mutt/1.5.6i Sender: dwmalone@maths.tcd.ie Cc: current@freebsd.org Subject: Re: Kern_symlink(...) is not setting vattr.va_type X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Feb 2006 13:59:39 -0000 On Mon, Feb 27, 2006 at 04:27:53PM +0530, Rohit Jalan wrote: > I've reproduced the following from vfs_syscalls.c,v 1.399. > Vattr.va_type is set only if MAC is defined, should not it > be set always? Or is setting the same a responsibility of > VOP_SYMLINK()? I think VOP_SYMLINK does the work for us. If you check back through the file's history, this line was added in revision 1.295 when the MAC framework was introduced. David.