From owner-freebsd-acpi@FreeBSD.ORG Wed Jun 16 20:54:41 2004 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7F29616A4CE for ; Wed, 16 Jun 2004 20:54:41 +0000 (GMT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id E3AC043D5F for ; Wed, 16 Jun 2004 20:54:40 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.11/8.12.11) with ESMTP id i5GKqg3B025154; Wed, 16 Jun 2004 14:52:42 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Wed, 16 Jun 2004 14:52:57 -0600 (MDT) Message-Id: <20040616.145257.88000637.imp@bsdimp.com> To: liamfoy@sepulcrum.org From: "M. Warner Losh" In-Reply-To: <20040616213946.6f7def3d.liamfoy@sepulcrum.org> References: <20040616.135044.85075412.imp@bsdimp.com> <20040616.142323.91757134.imp@bsdimp.com> <20040616213946.6f7def3d.liamfoy@sepulcrum.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: acpi@freebsd.org Subject: Re: apm problem X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jun 2004 20:54:41 -0000 In message: <20040616213946.6f7def3d.liamfoy@sepulcrum.org> Liam Foy writes: : > +#define APM_UNKNOWN 0xff /* Unknown in APM BIOS spec */ : : Do you not mean 0xffffffff ? No. 0xff is the right number here. The problem is that there's a number of different flag values, some which come directly from the APM BIOS, and others that are generated by the drivers. : I agree with the ai_infoversion change above, and from your other : mail about changing the number of batteries from 0 to -1. Has nate : gave any feedback ? Not yet. He's recovering from a massive disk crash right now. : I have also made some recent changes which have been commited which : have changed the structure of the apm code. I am willing to change : the code from >= 255 to == APM_UNKNOWN if it is decided this is what : the correct way and it is agreeded upon. I have the changes in my tree, and will work with Nate to get the right stuff committed. At the very least the 255's should be changed to a meaningful constant. Warner