From owner-freebsd-bugs@FreeBSD.ORG  Wed Feb 19 19:50:01 2014
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 998A3438
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Wed, 19 Feb 2014 19:50:01 +0000 (UTC)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 8198E1C65
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Wed, 19 Feb 2014 19:50:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id s1JJo1gH078699
 for <freebsd-bugs@freefall.freebsd.org>; Wed, 19 Feb 2014 19:50:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s1JJo1Mj078698;
 Wed, 19 Feb 2014 19:50:01 GMT (envelope-from gnats)
Date: Wed, 19 Feb 2014 19:50:01 GMT
Message-Id: <201402191950.s1JJo1Mj078698@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
Cc: 
From: oliver <oliver@beefrankly.org>
Subject: Re: bin/186294: calendar(1): calendar&#39; preprocessor process
 comments
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
Reply-To: oliver <oliver@beefrankly.org>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Feb 2014 19:50:01 -0000

The following reply was made to PR bin/186294; it has been noted by GNATS.

From: oliver <oliver@beefrankly.org>
To: bug-followup@FreeBSD.org, romain@FreeBSD.org
Cc:  
Subject: Re: bin/186294: calendar(1): calendar&#39; preprocessor process
 comments
Date: Wed, 19 Feb 2014 20:47:24 +0100

 Hello Romain,
 
 that is very true...when removing the original block, I didn't remove
 the while condition, even stepping through is not anymore required.
 
 Sorry, I will fix that. 
 
 For so long, please don't commit the patch. I'm digging a bit deeper
 for PR: bin/162211 and found another issue..please stand by, will
 post the corrected version shortly...but need to make other
 tests first.
 
 
 Greetings, Oliver
 
 
 
 >Hi Oliver,
 
 >On Wed, Feb 19, 2014 at 06:16:25PM +0100, oliver wrote:
 >> sorry wrong patch file, patch again - correct version.
 
 >After applying this patch, I confirm this problem is fixed.
 
 >> + } else if (idx_ts != NULL && idx_te == NULL) {
 >> + if (cf == 0) {
 >> + cf = 1;
 >> + while (buf++ != idx_ts); 
 > ^^^^^^^^^^^^^^^^^^^^^^^
 
 >While copying/pasting the patch, this line confused me a bit. Isn't it
 >more obvious to write this as a simple assignment ?
 
 >> buf = idx_ts + 1;
 
 >Thanks!
 
 >Romain