From owner-freebsd-net@FreeBSD.ORG  Tue Jul 12 18:54:55 2011
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D195A106566C
	for <freebsd-net@freebsd.org>; Tue, 12 Jul 2011 18:54:55 +0000 (UTC)
	(envelope-from fazaeli@sepehrs.com)
Received: from sepehrs.com (mail2.sepehrs.com [213.217.59.98])
	by mx1.freebsd.org (Postfix) with ESMTP id 1C3538FC0A
	for <freebsd-net@freebsd.org>; Tue, 12 Jul 2011 18:54:54 +0000 (UTC)
Received: from [127.0.0.1] ([192.168.3.10])
	by sepehrs.com (8.14.3/8.14.3) with ESMTP id p6CIoibH020250;
	Tue, 12 Jul 2011 23:20:45 +0430 (IRDT)
Message-ID: <4E1C9870.1070500@sepehrs.com>
Date: Tue, 12 Jul 2011 23:24:40 +0430
From: Hooman Fazaeli <fazaeli@sepehrs.com>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
	rv:1.9.2.18) Gecko/20110616 Thunderbird/3.1.11
MIME-Version: 1.0
To: Mike Tancsa <mike@sentex.net>
References: <icgd44$89l$1@dough.gmane.org>	<AANLkTinO1yfN--_K63-yD1LY3wusOF7wB2wwG8DUd5Z4@mail.gmail.com>	<4D2C636B.5040003@sentex.net>	<AANLkTimFzYZOkwdExm5JPRB7BaN8Am8pPcgrMT0wVZqy@mail.gmail.com>	<4D3C4795.40205@sentex.net>	<4D42EA74.4090807@sentex.net>	<1296590190.2326.6.camel@hitfishpass-lx.corp.yahoo.com>	<AANLkTimdJNV4Hxm6+i3uVa7es9Vu=TDAFBzfUycuM=sZ@mail.gmail.com>	<1296591565.2326.7.camel@hitfishpass-lx.corp.yahoo.com>	<AANLkTinD0q3r85fAj0Kju9Vc6fT-MVrR1LRczu_XaRW0@mail.gmail.com>	<AANLkTinAh1Hwf80ixVvQwk1DRZpvO26PMko3t94+5C0R@mail.gmail.com>	<1296597827.2326.12.camel@hitfishpass-lx.corp.yahoo.com>	<4D48C973.7080503@sentex.net>	<AANLkTinvEAe0b9vd5bvBUyhh8FO9uwXitTGFAEPCamWg@mail.gmail.com>	<4D49A26B.5050803@sentex.net>	<1296842996.2233.0.camel@hitfishpass-lx.corp.yahoo.com>	<AANLkTint=mMqGCK8vZbFpLsmgrcs20dHg7f8pV64d=U2@mail.gmail.com>	<4D4F3497.6050505@sentex.net>
	<4E141D01.3040203@sepehrs.com> <4E1438B8.9000409@sentex.net>
In-Reply-To: <4E1438B8.9000409@sentex.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "freebsd-net@freebsd.org" <freebsd-net@freebsd.org>
Subject: Re: em driver, 82574L chip, and possibly ASPM
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Jul 2011 18:54:55 -0000

tanx.

out of curiosity, can some one pls. explain this?

In if_em.c, function em_start_locked, there is:

     if (txr->tx_avail <= EM_TX_CLEANUP_THRESHOLD)
           em_txeof(txr);

inside while loop. While is if_igb.c, function igb_start_locked,
a similar code it is out of while loop:

       if (txr->tx_avail <= IGB_TX_CLEANUP_THRESHOLD)
                 igb_txeof(txr);

is this intentional or mistake?


On 7/6/2011 2:58 PM, Mike Tancsa wrote:
> On 7/6/2011 4:29 AM, Hooman Fazaeli wrote:
>> Can you pls. share the patch for freebsd 7?
> Its in the tree.
>
> http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/dev/e1000/
>
>
> 	---Mike
>