Date: Fri, 16 Nov 2012 08:02:39 -0800 From: mdf@FreeBSD.org To: Konstantin Belousov <kib@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r243134 - head/sys/sys Message-ID: <CAMBSHm_xwP5S8ERXYL%2Bsw%2BBAfgTAss9i0EGoX5%2B1Hy40PhfXbg@mail.gmail.com> In-Reply-To: <201211160625.qAG6PLd2032062@svn.freebsd.org> References: <201211160625.qAG6PLd2032062@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Nov 15, 2012 at 10:25 PM, Konstantin Belousov <kib@freebsd.org> wrote: > Author: kib > Date: Fri Nov 16 06:25:20 2012 > New Revision: 243134 > URL: http://svnweb.freebsd.org/changeset/base/243134 > > Log: > Alphabetically reorder the forward-declarations of the structures. > Add the declaration for enum idtype, to be used later. Forward declarations of enums isn't an ISO C feature, but a gcc extension. While the kernel uses many gcc extensions, it hides most under a #define so unsupported compilers can continue along. This unsupported feature can't be hidden. Does the forward declaration prevent another warning? Thanks, matthew > Reported and reviewed by: bde > MFC after: 28 days > > Modified: > head/sys/sys/syscallsubr.h > > Modified: head/sys/sys/syscallsubr.h > ============================================================================== > --- head/sys/sys/syscallsubr.h Fri Nov 16 06:22:14 2012 (r243133) > +++ head/sys/sys/syscallsubr.h Fri Nov 16 06:25:20 2012 (r243134) > @@ -35,25 +35,26 @@ > #include <sys/mount.h> > > struct file; > +enum idtype; > struct itimerval; > struct image_args; > struct jail; > +struct kevent; > +struct kevent_copyops; > +struct kld_file_stat; > +struct ksiginfo; > struct mbuf; > struct msghdr; > struct msqid_ds; > +struct ogetdirentries_args; > struct rlimit; > struct rusage; > -struct __wrusage; > union semun; > +struct sendfile_args; > struct sockaddr; > struct stat; > -struct kevent; > -struct kevent_copyops; > -struct kld_file_stat; > -struct ksiginfo; > -struct sendfile_args; > struct thr_param; > -struct ogetdirentries_args; > +struct __wrusage; > > int kern___getcwd(struct thread *td, u_char *buf, enum uio_seg bufseg, > u_int buflen);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMBSHm_xwP5S8ERXYL%2Bsw%2BBAfgTAss9i0EGoX5%2B1Hy40PhfXbg>