From owner-cvs-all Wed Feb 19 0: 5:44 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 85E4437B401; Wed, 19 Feb 2003 00:05:42 -0800 (PST) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6504C43F85; Wed, 19 Feb 2003 00:05:41 -0800 (PST) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.6/8.12.3) with ESMTP id h1J85e3Y044068; Wed, 19 Feb 2003 01:05:40 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Wed, 19 Feb 2003 01:01:24 -0700 (MST) Message-Id: <20030219.010124.23410261.imp@bsdimp.com> To: sibagaki@lsi.melco.co.jp Cc: shiba@freebsd.org, src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/pccard pccarddevs From: "M. Warner Losh" In-Reply-To: <20030219162137F.sibagaki@lsi.melco.co.jp> References: <200302151357.h1FDvru9021460@repoman.freebsd.org> <20030215.193910.121221310.imp@bsdimp.com> <20030219162137F.sibagaki@lsi.melco.co.jp> X-Mailer: Mew version 2.1 on Emacs 21.2 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message: <20030219162137F.sibagaki@lsi.melco.co.jp> Takeshi Shibagaki writes: : I think so, but I'm sad a little when the card is recognized as XI300 : Wireless but the card is YIS YWL-11B actually. ok. : In NetBSD, the card is indicated YIS Corp. YWL-11b because pccard : driver outputs CISTPL_VER1 strings. So it may be better to rewrite : like NetBSD in FreeBSD. I like this idea in general, but dispair that a few cards have really bad CIS. Maybe the right thing to do is to default the descrition to the CISTPL_VER1 strings, if available. The driver is free to override the description. Most drivers could simplify a little and rely on the CIS string to be a good descrition, while those that know the descrition is lacking could add their own. To be clear, you'd like to see a change like the following (my cisco 350 card serves as an example): OLD: an0: at port 0x100-0x13f irq 10 function 0 config 5 on pccard1 NEW: an0: at port 0x100-0x13f irq 10 function 0 config 5 on pccard1 "Aironet 350 Wireless LAN Adapter" comes from the if_an_pccard driver, while "Cisco Systems 350 Series Wireless LAN Adapter" comes from the cis node talked about above. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message