From owner-freebsd-bugs@FreeBSD.ORG  Fri Apr 27 14:40:11 2007
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@hub.freebsd.org
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 1DA6D16A407
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 27 Apr 2007 14:40:11 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40])
	by mx1.freebsd.org (Postfix) with ESMTP id 0F87913C48C
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 27 Apr 2007 14:40:11 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l3REeAa1048762
	for <freebsd-bugs@freefall.freebsd.org>; Fri, 27 Apr 2007 14:40:10 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l3REeAlE048761;
	Fri, 27 Apr 2007 14:40:10 GMT (envelope-from gnats)
Date: Fri, 27 Apr 2007 14:40:10 GMT
Message-Id: <200704271440.l3REeAlE048761@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Christoph Weber-Fahr <cwf-ml@arcor.de>
Cc: 
Subject: Re: misc/112126: netstat segfaults on unusual ICMP statistics
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Christoph Weber-Fahr <cwf-ml@arcor.de>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Apr 2007 14:40:11 -0000

The following reply was made to PR bin/112126; it has been noted by GNATS.

From: Christoph Weber-Fahr <cwf-ml@arcor.de>
To: Maxim Konovalov <maxim@macomnet.ru>, bug-followup@freebsd.org
Cc:  
Subject: Re: misc/112126: netstat segfaults on unusual ICMP statistics
Date: Fri, 27 Apr 2007 16:35:35 +0200

 Hello,
 
 Maxim Konovalov <maxim@macomnet.ru> wrote:
 > On Fri, 27 Apr 2007, 03:50+0200, Christoph Weber-Fahr wrote:
 >> Input histogram:
 >> echo reply: 12
 >> destination unreachable: 1
 >> echo: 41
 >> #20: 7
 >> icmp traceroute: 16
 >> mobile registration req: 25
 >> #37: 31
 >> 8
 >> 15
 >>
 >> Note the last two untagged values. They
 >> are created when the kernel, which in
 >> the meantime has a ICM_MAXTYPE at, say, 49,
 >> has logged 8 packets of type 44, and 15 of type 47.
 
 > icmpstat.icps_outhist and icps_inhist are definde this way:
 > 
 > u_long icps_outhist[ICMP_MAXTYPE + 1];
 > u_long icps_inhist[ICMP_MAXTYPE + 1];
 > 
 > How do you fit types > ICMP_MAXTYPE + 1 there?
 
 Not at all. We are debating the case when ICMP_MAXTYPE
 in the kernel gets raised without adapting netstat.
 
 To test this you would not only have had modified ping, but also
 recompiled a kernel with a modified ICMP_MAXTYPE.
 
 My scenario above assumed ICMP_MAXTYPE to be 49.
 
 Regards
 
 Christoph Weber-Fahr