From owner-svn-ports-head@FreeBSD.ORG  Wed Sep  5 06:00:36 2012
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D84681065673;
	Wed,  5 Sep 2012 06:00:35 +0000 (UTC)
	(envelope-from gerald@pfeifer.com)
Received: from ainaz.pair.com (ainaz.pair.com [209.68.2.66])
	by mx1.freebsd.org (Postfix) with ESMTP id 59FA48FC0A;
	Wed,  5 Sep 2012 06:00:35 +0000 (UTC)
Received: from [10.212.144.100] (unknown [12.46.213.11])
	by ainaz.pair.com (Postfix) with ESMTPSA id 322433F40F;
	Wed,  5 Sep 2012 02:00:29 -0400 (EDT)
Date: Wed, 5 Sep 2012 01:00:18 -0500 (CDT)
From: Gerald Pfeifer <gerald@pfeifer.com>
To: Mark Linimon <linimon@FreeBSD.org>, Max Khon <fjoe@FreeBSD.org>
In-Reply-To: <201209032047.q83Kl1dl041630@svn.freebsd.org>
Message-ID: <alpine.LNX.2.00.1209041827470.4718@trevally.site>
References: <201209032047.q83Kl1dl041630@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
	ports-committers@freebsd.org
Subject: Re: svn commit: r303619 - head/Mk
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the ports tree for head
	<svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>, 
	<mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
	<mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Sep 2012 06:00:36 -0000

On Mon, 3 Sep 2012, Mark Linimon wrote:
> +.if defined(USE_READLINE)
> +.if ${USE_READLINE} == "port" || ${OSVERSION} > 1000000
> +LIB_DEPENDS+=	readline.6:${PORTSDIR}/devel/readline
> +CPPFLAGS+=		-I${LOCALBASE}/include
> +LDFLAGS+=		-L${LOCALBASE}/lib -lreadline

These two clearly show that we finally should get over it and
add -I${LOCALBASE}/include and -L${LOCALBASE}/lib by default.

There must be thousands of cases where ports and Mk/bsd.*.mk
do this manually as of today.

> +CONFIGURE_ENV+=	CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
> +.endif

Really?

Something looks fundamentally wrong if you have to do this under
.if defined(USE_READLINE), at least past

  r270411 | erwin | 2011-03-07 07:32:05 +0000 (Mon, 07 Mar 2011) | 5 lines

  Pass CPPFLAGS to MAKE_ENV and CONFIGURE_ENV

  PR:             153625
  Submitted by:   gerald

How about the patch below?

Gerald

Index: bsd.port.mk
===================================================================
--- bsd.port.mk	(revision 303674)
+++ bsd.port.mk	(working copy)
@@ -1708,7 +1708,6 @@
 LIB_DEPENDS+=	readline.6:${PORTSDIR}/devel/readline
 CPPFLAGS+=		-I${LOCALBASE}/include
 LDFLAGS+=		-L${LOCALBASE}/lib -lreadline
-CONFIGURE_ENV+=	CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
 .endif
 .endif