From owner-svn-src-head@freebsd.org Tue Aug 21 23:52:33 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2E20E10836F4; Tue, 21 Aug 2018 23:52:33 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 989FE748DF; Tue, 21 Aug 2018 23:52:32 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-pf1-x441.google.com with SMTP id k19-v6so82832pfi.1; Tue, 21 Aug 2018 16:52:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=d5kTcuXLlmds5gMqexe6r7SaQ++XGipP8eP/fq10DVY=; b=L7WmeyWubh3lqvG/8emgsIuyoBCwtFQg6quGFXYkhR9jN3UKPbkI7VrQB4anPVOxAt LnJ7p31Ti0XUZ9PLRkjCG/i2wqs1e/OGrhq6weFkwSW9z2VmmJapbbG+yWO3D8a5QKNL 3TwKDgKu22zJ5wNV4m7v+GuXksgi5PzWVE9ZDxwGu2rce4ZIf/9IKbREAy4LQrOMliN9 q+KPXjNZ768pUOf5+hhCp3INvs+GmO/cFRekRdaDPoA70xUiuA0FV4iPZ9xEn366le3U wGllXR89VlZXesTaXNuaodiDsDQeT6E+liYziMwqf1v+t7yd4kB1mZN96FNnVwCfE8ph 3YGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=d5kTcuXLlmds5gMqexe6r7SaQ++XGipP8eP/fq10DVY=; b=c9MS3aiEKRqRlSrB/xWLaPDKeXNUD2rcenTvxU5/0mEjgaRl4Rcx7jX4R0TdUzlNyC NNbpWxQIDcBtX3SrOb0XRnRi8nsT2gI2N2VdsV5v2xX+r5XU+ZWbqSW1+YPG45itOX2R 9nK/6g3EZ1y5b4TCDxdeLYXV36X2vsBqsmfZM7rugWd2Qun+FuPc2WuDtxjATTpbhH1r 15q9sfZhEE6kZsuSJajmhtL/tiuEoeS4WomTu+wbvjsx11uElrxgYCJTwkrpwIp9OOdM kiYKJqjvYfd4dkk456PDm5PxfAghwMOHwgHRdmSOYPKmGvOxWVJduwz/y0T9yXvMW5Id pBzg== X-Gm-Message-State: AOUpUlHoi+s+/0cifAN+MomLCFVLf6tBn18+H/MJgpK7EBbtZYjF5e0h GkLjfP9IgsZbHMohgP86B9ODhzqwRQttmw== X-Google-Smtp-Source: AA+uWPy2rTUduxcxsGPnwEZSZ5YBHBELWwOORLP/l1PpI2NuvkYRljmwNBg6dux0UAXGZBZojaYgfQ== X-Received: by 2002:a63:ed4f:: with SMTP id m15-v6mr49193802pgk.147.1534895551437; Tue, 21 Aug 2018 16:52:31 -0700 (PDT) Received: from raichu (toroon0560w-lp130-09-70-52-224-239.dsl.bell.ca. [70.52.224.239]) by smtp.gmail.com with ESMTPSA id r25-v6sm68722pgm.59.2018.08.21.16.52.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Aug 2018 16:52:30 -0700 (PDT) Sender: Mark Johnston Date: Tue, 21 Aug 2018 19:52:27 -0400 From: Mark Johnston To: Matthew Macy Cc: Gleb Smirnoff , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r337866 - in head/sys: net netinet netinet6 Message-ID: <20180821235227.GB55580@raichu> References: <201808152023.w7FKN9LL055254@repo.freebsd.org> <20180821212047.GM27633@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Aug 2018 23:52:33 -0000 On Tue, Aug 21, 2018 at 04:00:10PM -0700, Matthew Macy wrote: > Yes. See r338162. Thanks. You missed instances of the same bug in in_mcast.c and in6_mcast.c. > On Tue, Aug 21, 2018 at 2:24 PM Gleb Smirnoff wrote: > > On Wed, Aug 15, 2018 at 08:23:09PM +0000, Matt Macy wrote: > > M> @@ -3772,8 +3775,11 @@ if_delmulti_locked(struct ifnet *ifp, struct > > ifmultiad > > M> ll_ifma->ifma_ifp = NULL; /* XXX */ > > M> if (--ll_ifma->ifma_refcount == 0) { > > M> if (ifp != NULL) { > > M> - CK_STAILQ_REMOVE(&ifp->if_multiaddrs, > > ll_ifma, ifmultiaddr, > > M> - ifma_link); > > M> + if (ll_ifma->ifma_flags & IFMA_F_ENQUEUED) > > { > > M> + > > CK_STAILQ_REMOVE(&ifp->if_multiaddrs, ll_ifma, ifmultiaddr, > > M> + ifma_link); > > M> + ifma->ifma_flags &= > > ~IFMA_F_ENQUEUED; > > M> + } > > M> } > > M> if_freemulti(ll_ifma); > > M> } > > > > Coverity suggested there is a cut and paste mistake here, and it is > > compilable. > > After quick glance I tend to agree. Looks like flag is cleared on wrong > > ifma. > > > > -- > > Gleb Smirnoff > >