Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 08 Jun 2018 09:27:31 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 227109] Mk/Scripts, cleanup using devel/hs-ShellCheck
Message-ID:  <bug-227109-7788-t0x3dpBskV@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-227109-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-227109-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D227109

--- Comment #23 from commit-hook@freebsd.org ---
A commit references this bug:

Author: mat
Date: Fri Jun  8 09:26:32 UTC 2018
New revision: 471991
URL: https://svnweb.freebsd.org/changeset/ports/471991

Log:
  SC2015: Note that A && B || C is not if-then-else. C may run when A is tr=
ue.

  It's common to use A && B to run B when A is true, and A || C to run C
  when A is false.

  However, combining them into A && B || C is not the same as if A then B
  else C.

  In this case, if A is true but B is false, C will run.

  If an if clause is used instead, this problem is avoided.

  PR:             227109
  Submitted by:   mat
  Sponsored by:   Absolight

Changes:
  head/Mk/Scripts/qa.sh

--=20
You are receiving this mail because:
You are on the CC list for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-227109-7788-t0x3dpBskV>