From owner-svn-src-all@FreeBSD.ORG Wed Mar 10 23:46:30 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6A217106564A; Wed, 10 Mar 2010 23:46:30 +0000 (UTC) (envelope-from peterjeremy@acm.org) Received: from mail17.syd.optusnet.com.au (mail17.syd.optusnet.com.au [211.29.132.198]) by mx1.freebsd.org (Postfix) with ESMTP id E76CD8FC1A; Wed, 10 Mar 2010 23:46:29 +0000 (UTC) Received: from server.vk2pj.dyndns.org (c122-106-253-149.belrs3.nsw.optusnet.com.au [122.106.253.149]) by mail17.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id o2ANkQRg002692 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 11 Mar 2010 10:46:27 +1100 X-Bogosity: Ham, spamicity=0.000000 Received: from server.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1]) by server.vk2pj.dyndns.org (8.14.3/8.14.3) with ESMTP id o2ANkP2W069740; Thu, 11 Mar 2010 10:46:25 +1100 (EST) (envelope-from peter@server.vk2pj.dyndns.org) Received: (from peter@localhost) by server.vk2pj.dyndns.org (8.14.3/8.14.3/Submit) id o2ANkPB0069739; Thu, 11 Mar 2010 10:46:25 +1100 (EST) (envelope-from peter) Date: Thu, 11 Mar 2010 10:46:25 +1100 From: Peter Jeremy To: Marius Strobl Message-ID: <20100310234625.GA69658@server.vk2pj.dyndns.org> References: <201003101955.o2AJtmrP046136@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="huq684BweRXVnRxX" Content-Disposition: inline In-Reply-To: <201003101955.o2AJtmrP046136@svn.freebsd.org> X-PGP-Key: http://members.optusnet.com.au/peterjeremy/pubkey.asc User-Agent: Mutt/1.5.20 (2009-06-14) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r204974 - head/lib/libc/sparc64/fpu X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Mar 2010 23:46:30 -0000 --huq684BweRXVnRxX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable One bug that crept in somewhere: On 2010-Mar-10 19:55:48 +0000, Marius Strobl wrote: >Modified: head/lib/libc/sparc64/fpu/fpu.c >@@ -181,15 +182,11 @@ __fpu_dumpfpn(struct fpn *fp) > } > #endif >=20 >-static int opmask[] =3D {0, 0, 1, 3}; >+static const int opmask[] =3D {0, 0, 1, 3, 1}; >=20 =2E.. >Modified: head/lib/libc/sparc64/fpu/fpu_emu.h >=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >--- head/lib/libc/sparc64/fpu/fpu_emu.h Wed Mar 10 19:55:27 2010 (r204973) >+++ head/lib/libc/sparc64/fpu/fpu_emu.h Wed Mar 10 19:55:48 2010 (r204974) >@@ -140,7 +140,7 @@ struct fpn { > #define FTYPE_SNG INSFP_s > #define FTYPE_DBL INSFP_d > #define FTYPE_EXT INSFP_q >-#define FTYPE_LNG -1 >+#define FTYPE_LNG 5 FTYPE_* are used as indexes into opmask[]. Somewhere along the line, FTYPE_LNG has changed from 4 to 5 but the opmask[] initialisers still assume 4. (It might be worth adding a comment into opmask[] so this relationship is noted in future). --=20 Peter Jeremy --huq684BweRXVnRxX Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkuYL1EACgkQ/opHv/APuIcZygCdFUUbJsCEYa+hxoib53TcKu0x bCIAnj0t8dJ8nZb6TLkyqLzjsBZw4+hH =PZ6y -----END PGP SIGNATURE----- --huq684BweRXVnRxX--