Date: Wed, 3 Oct 2012 11:49:33 +0300 From: Boris Astardzhiev <boris.astardzhiev@gmail.com> To: Grzegorz Bernacki <gber@freebsd.org> Cc: freebsd-fs@freebsd.org, stanislav_galabov@smartcom.bg Subject: Re: libstand's NANDFS superblock detection fix Message-ID: <CAP=KkTwmpz-%2BffS7RPwH=CyMmNeT8ccO0wEjT4tF4D1ATG9H0Q@mail.gmail.com> In-Reply-To: <506C082B.8000207@freebsd.org> References: <CAP=KkTzMeWVh=NavOOgzytyOf_Qjr2S3tSYZNmFxEZWg%2Bn0GOA@mail.gmail.com> <506C082B.8000207@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--f46d0408393bbea7c604cb23b7bd Content-Type: text/plain; charset=ISO-8859-1 Hello, About the checkpoint numbers - we have noticed that libstand-nandfs' judgement is by sb->s_wtime whereas kernelspace does it by sb->s_last_cno (sys/fs/nandfs/nandfs_vfsops.c:1590). The patch is attached without the #if 0 part and is ready to be submitted. I don't have commit privileges and I don't know the right procedure further. Do I need to send a PR or something else? I'll anticipate your reply. Greetings, Boris On Wed, Oct 3, 2012 at 12:40 PM, Grzegorz Bernacki <gber@freebsd.org> wrote: > On 10/02/12 17:00, Boris Astardzhiev wrote: > >> Hello, >> >> On behalf of Smartcom Bulgaria AD I would like to contribute a patch for >> libstand's NANDFS support in FreeBSD. >> It is related to the correct detection of a superblock when accessing >> the filesystem. It's also been noticed that >> the election of a superblock between kernelspace and libstand's one >> differs regarding the checkpoint number. >> The patch is attached. >> >> Comments will be appreciated. >> >> Greetings, >> Boris Astardzhiev / Smartcom Bulgaria AD >> > > Hello Boris, > > Patch looks fine. Just remove code under #if 0 and it can be submitted. > Please let me know if you want to do it or you can do it yourself. > Give me some more time and I will check checkpoint number differs you > mentioned. > > thanks a lot for you contribution, > grzesiek > --f46d0408393bbea7c604cb23b7bd Content-Type: application/octet-stream; name="nand-sb.diff" Content-Disposition: attachment; filename="nand-sb.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_h7u62st40 ZGlmZiAtLWdpdCBhL2xpYi9saWJzdGFuZC9uYW5kZnMuYyBiL2xpYi9saWJzdGFuZC9uYW5kZnMu YwppbmRleCA2N2UyZmVhLi5kNWZjYjlkIDEwMDY0NAotLS0gYS9saWIvbGlic3RhbmQvbmFuZGZz LmMKKysrIGIvbGliL2xpYnN0YW5kL25hbmRmcy5jCkBAIC0xNzUsNyArMTc1LDcgQEAgc3RhdGlj IGludAogbmFuZGZzX2ZpbmRfc3VwZXJfYmxvY2soc3RydWN0IG5hbmRmcyAqZnMsIHN0cnVjdCBv cGVuX2ZpbGUgKmYpCiB7CiAJc3RydWN0IG5hbmRmc19zdXBlcl9ibG9jayAqc2I7Ci0JaW50IGks IGosIG47CisJaW50IGksIGosIG4sIHM7CiAJaW50IHNlY3RvcnNfdG9fcmVhZCwgZXJyb3I7CiAK IAlzYiA9IG1hbGxvYyhmcy0+bmZfc2VjdG9yc2l6ZSk7CkBAIC0xOTYsMjMgKzE5NiwyMiBAQCBu YW5kZnNfZmluZF9zdXBlcl9ibG9jayhzdHJ1Y3QgbmFuZGZzICpmcywgc3RydWN0IG9wZW5fZmls ZSAqZikKIAkJCWNvbnRpbnVlOwogCQl9CiAJCW4gPSBmcy0+bmZfc2VjdG9yc2l6ZSAvIHNpemVv ZihzdHJ1Y3QgbmFuZGZzX3N1cGVyX2Jsb2NrKTsKKwkJcyA9IDA7CiAJCWlmICgoaSAqIGZzLT5u Zl9zZWN0b3JzaXplKSAlIGZzLT5uZl9mc2RhdGEtPmZfZXJhc2VzaXplID09IDApIHsKIAkJCWlm IChmcy0+bmZfc2VjdG9yc2l6ZSA9PSBzaXplb2Yoc3RydWN0IG5hbmRmc19mc2RhdGEpKQogCQkJ CWNvbnRpbnVlOwogCQkJZWxzZSB7Ci0JCQkJc2IgKz0gKHNpemVvZihzdHJ1Y3QgbmFuZGZzX2Zz ZGF0YSkgLwotCQkJCSAgICBzaXplb2Yoc3RydWN0IG5hbmRmc19zdXBlcl9ibG9jaykpOwotCQkJ CW4gLT0gKHNpemVvZihzdHJ1Y3QgbmFuZGZzX2ZzZGF0YSkgLworCQkJCXMgKz0gKHNpemVvZihz dHJ1Y3QgbmFuZGZzX2ZzZGF0YSkgLwogCQkJCSAgICBzaXplb2Yoc3RydWN0IG5hbmRmc19zdXBl cl9ibG9jaykpOwogCQkJfQogCQl9CiAKLQkJZm9yIChqID0gMDsgaiA8IG47IGorKykgeworCQlm b3IgKGogPSBzOyBqIDwgbjsgaisrKSB7CiAJCQlpZiAoIW5hbmRmc19jaGVja19zdXBlcmJsb2Nr X2NyYyhmcy0+bmZfZnNkYXRhLCAmc2Jbal0pKQogCQkJCWNvbnRpbnVlOwotCQkJTkFOREZTX0RF QlVHKCJtYWdpYyAleCB3dGltZSAlamRcbiIsIHNiLT5zX21hZ2ljLAotCQkJICAgIHNiLT5zX3d0 aW1lKTsKLQkJCWlmIChzYltqXS5zX3d0aW1lID4gZnMtPm5mX3NiLT5zX3d0aW1lKQorCQkJTkFO REZTX0RFQlVHKCJtYWdpYyAleCB3dGltZSAlamQsIGxhc3RjcCAweCVqeFxuIiwKKwkJCSAgICBz YltqXS5zX21hZ2ljLCBzYltqXS5zX3d0aW1lLCBzYltqXS5zX2xhc3RfY25vKTsKKwkJCWlmIChz YltqXS5zX2xhc3RfY25vID4gZnMtPm5mX3NiLT5zX2xhc3RfY25vKQogCQkJCW1lbWNweShmcy0+ bmZfc2IsICZzYltqXSwgc2l6ZW9mKCpmcy0+bmZfc2IpKTsKIAkJfQogCX0K --f46d0408393bbea7c604cb23b7bd--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAP=KkTwmpz-%2BffS7RPwH=CyMmNeT8ccO0wEjT4tF4D1ATG9H0Q>