From owner-svn-src-all@freebsd.org Wed Sep 18 12:41:10 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D0018FC894; Wed, 18 Sep 2019 12:41:10 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46YKN65CNSz4GWK; Wed, 18 Sep 2019 12:41:10 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 86CCDB35; Wed, 18 Sep 2019 12:41:10 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qk1-f179.google.com with SMTP id z67so7780681qkb.12; Wed, 18 Sep 2019 05:41:10 -0700 (PDT) X-Gm-Message-State: APjAAAUUZgb3HwME7Lr8199XMEoQ7yWJodpI6dp8LQkPOl/0YGwiYNhE akZywzljalb7DSYNU80XmgdW6/JBX0cYNsGly84= X-Google-Smtp-Source: APXvYqwM4aMIPsImbYq2hcrZmskdd+GqvjN5vJB4rgwck3Voahpxhe3OoBKHq+ZZG6eBNyCbmfA9HSmbJSPjxcx8458= X-Received: by 2002:ae9:dd81:: with SMTP id r123mr3685582qkf.103.1568810469982; Wed, 18 Sep 2019 05:41:09 -0700 (PDT) MIME-Version: 1.0 References: <201909180158.x8I1wuZu011258@repo.freebsd.org> <0FBC9A62-AE3B-4F27-AABC-06FF45F415F1@gmail.com> In-Reply-To: <0FBC9A62-AE3B-4F27-AABC-06FF45F415F1@gmail.com> From: Kyle Evans Date: Wed, 18 Sep 2019 07:40:58 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r352465 - head/share/mk To: Enji Cooper Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Sep 2019 12:41:10 -0000 On Wed, Sep 18, 2019 at 7:34 AM Enji Cooper wrote: > > > > On Sep 17, 2019, at 18:58, Kyle Evans wrote: > > > > Author: kevans > > Date: Wed Sep 18 01:58:56 2019 > > New Revision: 352465 > > URL: https://svnweb.freebsd.org/changeset/base/352465 > > > > Log: > > googletest: default-disable on all of MIPS for now > > > > Parts of the fusefs tests trigger a bug in current versions of llvm: IR > > representation of some routine for the MIPS targets is a function with a > > large number of arguments. This then leads the compiler on an hour+ long > > goose chase, which is OK if you build the current tree but less-so if you're > > trying external toolchain or doing a universe build involving mips when it > > eventually gets switched over to LLVM. > > > > Better, accurate details can be found in LLVM PR43263. > > Uhhhhh... why not do this in tests/sys/... instead? Because there's still value in being able to easily enable these for building/running the complete set of tests through standard build infrastructure, but it's not worth adding a knob specifically for the fusefs tests. I also prefer the communication of it being an off-by-default option and easily deduced from src.conf(5) that this part of the build is default-disabled on mips/mips.