From owner-svn-src-head@freebsd.org Fri Jan 17 19:46:45 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C50201F926D; Fri, 17 Jan 2020 19:46:45 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47zs5K4qlgz41Xw; Fri, 17 Jan 2020 19:46:45 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-wr1-x444.google.com with SMTP id d16so23856714wre.10; Fri, 17 Jan 2020 11:46:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=yYg0w4BEfH/3WciYd3azPgYk0ltBP+dlCEKsTtRTBjQ=; b=WMHHdRPECO+7vrVoKvWfikPdfRDN85at4yZhGZUHNTNVUUiNsEwTiHhlzBP4Qku9uK L0DK2j+Pa5L/NHEPs2eO5k+swgU4/PnxwwCF/QC1A82kAp5XJ26/JbGn5p/vRGOIlbce 1qrUSo4LlID6pyjH3D4Zp7dClPj8ve8nzntAkRKFZEoHsaJNKZw9+encXZ4VIKi3pU/h VvbBUKUD9aJzD8tUKv+K/pFkpY1ezlj5IBW8uBstTT48b4Rb0tnX1lXYjh8WYIpg958f zLwJ2RRz0mBQ8LIoC+n8hymBHHWZOb05R8E+0OpJpVYMxYAev95dMn4EITUbiC+xQPj+ M1CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=yYg0w4BEfH/3WciYd3azPgYk0ltBP+dlCEKsTtRTBjQ=; b=i5mNSql3AWrTYu0cdiOA5Cz+mEeWmyH223Oz+Z1HKkKYgeBc9XreoyS9IfaA5DkExg K9hOTZWzTVcQ9fi1QMZXg8rixGJ3Rovc7kzbPvQfZzACZn6zF6lEz7mhMHxQfPttzOmo wsXbKMX0rJaiXJ2AfP4uJyNNBYN/0A8EZYrCusvyd+Qxs/v4V9D2BSyqcHABL3hG5cpC r4ALKwgIn1E+tpFYW8CcEEYzeJoU6Zw9gJfj+EM89wo88EmviE9SJsY7NVbAem9m+Qfh 0XAbzTzwsOCXyL6qoq6W0Hve5zWhZXklhzYHtwPXdrE1nM69OkbIcrEc1WUQ0Yr4C8XK tfrA== X-Gm-Message-State: APjAAAWwcntLfGqMNbxs8+kLpyz+61ujihmnu4/rL0hYZv6Cn4oy+crP fQcktbjgAuRRn/et894DXeETxyBwT7+b3wEzxdw1aw== X-Google-Smtp-Source: APXvYqycg3aDYVZB5SgWLVkFJ6009Mx7CsscOahI/JG8OYP9IQMGjhCcdiSOLum/dhG2zdFdIp/mP3p+fpgPMOzqIZ4= X-Received: by 2002:a5d:4651:: with SMTP id j17mr4802594wrs.237.1579290402906; Fri, 17 Jan 2020 11:46:42 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a5d:6b02:0:0:0:0:0 with HTTP; Fri, 17 Jan 2020 11:46:42 -0800 (PST) In-Reply-To: <75C1E5B4-41B3-4C97-9794-1D684884A0E5@FreeBSD.org> References: <202001171545.00HFjdMw003501@repo.freebsd.org> <75C1E5B4-41B3-4C97-9794-1D684884A0E5@FreeBSD.org> From: Mateusz Guzik Date: Fri, 17 Jan 2020 20:46:42 +0100 Message-ID: Subject: Re: svn commit: r356832 - head/lib/libc/gen To: Dimitry Andric Cc: src-committers , svn-src-all , svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 47zs5K4qlgz41Xw X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jan 2020 19:46:45 -0000 On 1/17/20, Dimitry Andric wrote: > On 17 Jan 2020, at 16:45, Mateusz Guzik wrote: >> >> Author: mjg >> Date: Fri Jan 17 15:45:39 2020 >> New Revision: 356832 >> URL: https://svnweb.freebsd.org/changeset/base/356832 >> >> Log: >> libc: fix build after r356830 >> >> Apparently building with 'cd lib/libc; make all install' is not the same >> as buildworld. > > Definitely not, indeed. Such a plain make will use your system's > headers for inclusion, not those in /usr/src. Only use this when you > are certain those headers are up-to-date (or up-to-date enough ;). > That's not the difference I meant. Building like above works fine with: unionstack = _fcntl(fd, F_ISUNIONSTACK); It's only buildworld during which this fails with: /usr/src/lib/libc/gen/opendir.c:282:40: error: too few arguments provided to function-like macro invocation unionstack = _fcntl(fd, F_ISUNIONSTACK); hence the patch. -- Mateusz Guzik