From owner-dev-commits-ports-all@freebsd.org Wed Jun 2 04:16:29 2021 Return-Path: Delivered-To: dev-commits-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E7E276399E1; Wed, 2 Jun 2021 04:16:29 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FvwhF6GX5z3hjt; Wed, 2 Jun 2021 04:16:29 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1622607389; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hKjN4YxlhN3dMY9acLfe6ZAP62nYYaSYq+Ze8qWj524=; b=sOhrVozdV0to7rDm+VsayBXTrLdvosLcl/2WcioNF89z/p/Yv4jyGIvksauznLBMzBg1zD 1Txa7VlLMyMMo85s2TqdjkFpbuowV34q9AQSMNJ+Wk+thWwsKEtfzNRrS567FyxsszzfNl vH91Cu+C6Jd14XCHOy/RBlboFzUKgmYhgoWKBZOdzYb51P1ApMq2+RnZve/4TIjtLmRYLN e/pqSYPan5igUmBRGCUM7Fi/8svXjAJ6g7vJX/a8LpSzlyw5th/t//F7NjAeYk41D5PPLQ d71sYRePUFOKjGUsKK+bxzo5sVQiyMZOEjAid9Y7UApRk8hqCJKgf+aVy3BHRQ== Received: by freefall.freebsd.org (Postfix, from userid 1033) id AF8C0131FD; Wed, 2 Jun 2021 04:16:29 +0000 (UTC) Date: Wed, 2 Jun 2021 04:16:29 +0000 From: Alexey Dokuchaev To: Guangyuan Yang Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: f1e718499cb3 - main - www/civetweb: New port: Embedded C/C++ web server Message-ID: References: <202106020218.1522Io42007503@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202106020218.1522Io42007503@gitrepo.freebsd.org> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1622607389; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hKjN4YxlhN3dMY9acLfe6ZAP62nYYaSYq+Ze8qWj524=; b=PdD5fRvzEeBqMU0/bGJZV4dUe7gK6G7DIrufLVR8juEBT/y22GXcvZQMD9NSA7cUhLF0wO 0ZPy68wYH/nmVeHG0fSSnvd1uke7MwiNkctYquncMFdQ6+lq8JIDdu4ZAg28FB62SLoZD3 qkHPcq16YsGGlxrLTmQqSr3Kfo7sDRxbIetAtW9bbF1r1eHZElclmV7CSI/idUqyb0Jv5m Hnw2JSN1+5u1K1ZR3SstbJYAV73yjxZsGpo99EU0IAPJbnOCHV4hppWSIYZf9+AsET9yK5 XdwTKSFL03GoACkL93lpXhJq/KF9Ge0ZypyJGvo2hKP4xAVTCXeaydzpHBUPEQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1622607389; a=rsa-sha256; cv=none; b=HgPIM/u2QmgDetc1hFlOXhCTGS1foEBNPFJWue5PcDSaYHXnZpwZVoGitfzljZYAPdLX2F afTtbk+OwzR91JN6mTsox42mo+1LmwQVDP6sVOAw/jdvIznZlYLe3wxMoRtEHC3s9M4SL8 AZbxGorH23JtZKejY5PDWs1lZrDmw+q5FO/m6TL2sMGOwpnBYlex94gtJpWDZHw7xW4gou K3rWhJiB8TNP9EBXvw1akFkjG60/Iaxgu5bGCwBWm9nE/RXuIy1DOmZ5KqVOfnvKtqn3im 2BVD0ozWe5CoDT8vRYC95m50MWtCUi35BpyF3p2kIjzackQtEsyORgoZJLrg9Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: dev-commits-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jun 2021 04:16:30 -0000 On Wed, Jun 02, 2021 at 02:18:50AM +0000, Guangyuan Yang wrote: > commit f1e718499cb309115b622453026bbacc4af60d73 > > www/civetweb: New port: Embedded C/C++ web server > > PR: 255974 > Approved by: lwhsu (mentor) Looks like it was not thorougly reviewed prior to approval. > ... > --- /dev/null > +++ b/www/civetweb/Makefile > @@ -0,0 +1,21 @@ > +# Created by: maintainer.freebsd@xpoundit.com > + > +PORTNAME= civetweb > +DISTVERSIONPREFIX= v > +DISTVERSION= 1.14 > +CATEGORIES= www > + > +MAINTAINER= maintainer.freebsd@xpoundit.com > +COMMENT= Embedded C/C++ web server This text makes a nice COMMENT, ... > --- /dev/null > +++ b/www/civetweb/pkg-descr > @@ -0,0 +1,3 @@ > +Embedded C/C++ web server > + > +WWW: https://github.com/civetweb/civetweb ... but very bad port description. It should not be the same as COMMENT verbatim. I should also terminate with a full stop (period). Please (re)read the PHB Section 3.2.1 on how a good pkg-descr file should look like. (Your mentor should have told you this.) ./danfe