From nobody Fri Feb 6 03:38:53 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f6fvd4Hw9z6FY8Y for ; Fri, 06 Feb 2026 03:38:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f6fvd1SRhz3QZq for ; Fri, 06 Feb 2026 03:38:53 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770349133; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bckRdTmrh4IdTSUYqEjXsNnf/9v/QnXPfLbj8+n1EZM=; b=UIJrSQwQrGFDKQbQf5RDtIlQOBOX6Buxc/1/7+IHO08QbuVmXtePzsxWyVh+gFrBrFMi4k loGJIsQBhF2Z9/UMz+MB4BoGsbqU673BT4G5l/CFaBpjTTLKNGRg0C56alFJHdT98oBXiV Jnwz6Xq9joxdESe3AtzPg7derm2NVpYkDcZQ9hx9OxO/5c4ArXK5ETr/8bqY7RM7U8hPGU OLTA50UhahKnMvuGoeCha2qN5m2Dvps50NHn6XtWx3uZC6CJQNRzvPUTs3eRC2TmAZd5mO MpwKdzfOjG18pIS8vf2y0mFof0bq/YytwBokjIBPAvDr0k7iX+28VY10M5JcLQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770349133; a=rsa-sha256; cv=none; b=O/Ui+PB45jRWBJk4T9PDuiZuhX8s/QZDLDpA3SGvNHq6LVunkHkR9Aa18Qw2d/MJXdcqgf NzweX+G8rjen4t73mGm/90PY/HU0wbbS39ggCfBxW9sW0/9sirUy7t82i8g9PXNxHuQzFx 2JlY8gVsNCfvcrCPJZiE52zEmyX7VzuJOJcYd7wSlJc4i6Wf+zjNTTA0kFxqgT/ruOCpnR Bsdu4mpqJVTQtORthMcnY65dYBrBuNipvc2FT8CfGkwv8RB435SpwWeK89oHXzS1EwWFLZ oHBb4vse0uM3HpUlBLpNG+su2Bf22mFMPCjH6CH0mfinRul0PYrqImVcpgzr7g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770349133; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bckRdTmrh4IdTSUYqEjXsNnf/9v/QnXPfLbj8+n1EZM=; b=AFnAb6+YLjj443GMUmsgf1UsYGYza/HOrb+lb0xbICCzE/1iu6cajsWZ+p48EDaQdH79QT bvSAUKkprlTyCZ2eZkZrmkM4DTfyEocrSU+HR3z03Rky/ayVTLQxMZslIWh6CA0YS9yWJu qIVfM7LwJxkDyG+odqvL6uN8I70wQPyUBD4G4sOHAZVIonAesxDmW8OyISVICVnku4hQAa 7PTKwxkIMz6Rk9nfTJ7GBfOqlCIWP0TkL9C5r16h6d02WYvWYM+WGHx/wAMh62vAwYJVrn r33HW7ywzZinT6aQ4vjFFHF45y9qAW9SkQEHxk2ZaNWKxanaD6muG4R/esIS1w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f6fvd0YfBzymR for ; Fri, 06 Feb 2026 03:38:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 42ebc by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 06 Feb 2026 03:38:53 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Zhenlei Huang Subject: git: 5ba503fc2cab - main - lagg: Remove the member pr_num from struct lagg_proto List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5ba503fc2cabc1a614997f102ace671d996bcc53 Auto-Submitted: auto-generated Date: Fri, 06 Feb 2026 03:38:53 +0000 Message-Id: <6985624d.42ebc.bf1d1b0@gitrepo.freebsd.org> The branch main has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=5ba503fc2cabc1a614997f102ace671d996bcc53 commit 5ba503fc2cabc1a614997f102ace671d996bcc53 Author: Zhenlei Huang AuthorDate: 2026-02-06 03:37:43 +0000 Commit: Zhenlei Huang CommitDate: 2026-02-06 03:37:43 +0000 lagg: Remove the member pr_num from struct lagg_proto It is set but never used. Remove it to avoid confusion and save a little space. While here, use designated initializers to initialize the LAGG protocol table. That improves readability, and it will be safer to initialize the table if we introduce new protocols in the future. No functional change intended. Reviewed by: glebius MFC after: 5 days Differential Revision: https://reviews.freebsd.org/D55124 --- sys/net/if_lagg.c | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/sys/net/if_lagg.c b/sys/net/if_lagg.c index 21ea2b30459b..1e4d3d8d85ac 100644 --- a/sys/net/if_lagg.c +++ b/sys/net/if_lagg.c @@ -208,7 +208,6 @@ static struct mbuf *lagg_default_input(struct lagg_softc *, struct lagg_port *, /* lagg protocol table */ static const struct lagg_proto { - lagg_proto pr_num; void (*pr_attach)(struct lagg_softc *); void (*pr_detach)(struct lagg_softc *); int (*pr_start)(struct lagg_softc *, struct mbuf *); @@ -223,24 +222,20 @@ static const struct lagg_proto { void (*pr_request)(struct lagg_softc *, void *); void (*pr_portreq)(struct lagg_port *, void *); } lagg_protos[] = { - { - .pr_num = LAGG_PROTO_NONE, + [LAGG_PROTO_NONE] = { .pr_start = lagg_none_start, .pr_input = lagg_none_input, }, - { - .pr_num = LAGG_PROTO_ROUNDROBIN, + [LAGG_PROTO_ROUNDROBIN] = { .pr_attach = lagg_rr_attach, .pr_start = lagg_rr_start, .pr_input = lagg_default_input, }, - { - .pr_num = LAGG_PROTO_FAILOVER, + [LAGG_PROTO_FAILOVER] = { .pr_start = lagg_fail_start, .pr_input = lagg_fail_input, }, - { - .pr_num = LAGG_PROTO_LOADBALANCE, + [LAGG_PROTO_LOADBALANCE] = { .pr_attach = lagg_lb_attach, .pr_detach = lagg_lb_detach, .pr_start = lagg_lb_start, @@ -248,8 +243,7 @@ static const struct lagg_proto { .pr_addport = lagg_lb_port_create, .pr_delport = lagg_lb_port_destroy, }, - { - .pr_num = LAGG_PROTO_LACP, + [LAGG_PROTO_LACP] = { .pr_attach = lagg_lacp_attach, .pr_detach = lagg_lacp_detach, .pr_start = lagg_lacp_start, @@ -263,8 +257,7 @@ static const struct lagg_proto { .pr_request = lacp_req, .pr_portreq = lacp_portreq, }, - { - .pr_num = LAGG_PROTO_BROADCAST, + [LAGG_PROTO_BROADCAST] = { .pr_start = lagg_bcast_start, .pr_input = lagg_default_input, },