Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 19 Aug 2020 17:48:45 +0000
From:      bugzilla-noreply@freebsd.org
To:        gnome@FreeBSD.org
Subject:   [Bug 248407] print/harfbuzz: Update to 2.7.1 and switch to meson
Message-ID:  <bug-248407-6497-KzO72ScyU0@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-248407-6497@https.bugs.freebsd.org/bugzilla/>
References:  <bug-248407-6497@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D248407

Jan Beich <jbeich@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|jbeich@FreeBSD.org          |gnome@FreeBSD.org
           Assignee|gnome@FreeBSD.org           |jbeich@FreeBSD.org
         Resolution|---                         |FIXED
             Status|New                         |Closed

--- Comment #7 from Jan Beich <jbeich@FreeBSD.org> ---
Thanks. Landed with minor changes (see below).

> +USES=3D		compiler:c++11-lib gettext-runtime gnome meson \
> +		pkgconfig python:build shebangfix

USES=3Dgettext-runtime isn't used anymore because USES=3Dmeson has implicit
-Wl,--as-needed but -lintl was previously overlinked due to USE_GNOME=3Dgli=
b20
(see "pkg-config glib-2.0 --libs")

> .if ${HARFBUZZ_SLAVE} =3D=3D no
> OPTIONS_DEFINE=3D	DOCS TEST
> OPTIONS_SUB=3D	yes
> .endif
>=20
> MESON_ARGS=3D	-Dglib=3Denabled -Dgobject=3Denabled -Dgraphite=3Denabled \
> 		-Dfreetype=3Denabled -Dbenchmark=3Ddisabled
>=20
> PLIST_SUB+=3D	LIBVER=3D0.20701.0
>=20
> .if ${HARFBUZZ_SLAVE} =3D=3D no
> DOCS_BUILD_DEPENDS=3D	gtkdoc-scan:textproc/gtk-doc
> DOCS_MESON_ENABLED=3D	docs
> TEST_MESON_ENABLED=3D	tests
> .endif

Readability here was poor:
- Global flags (MESON_ARGS, PLIST_SUB) mixed with OPTION-specific flags
(*_ENABLED)
- More than one conditional to handle OPTION-specific flags

> TEST_TARGET=3D	test

Already defined by default via USES=3Dmeson.

--=20
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-248407-6497-KzO72ScyU0>