Date: Tue, 07 Nov 2006 12:37:39 -0500 From: Randall Stewart <rrs@cisco.com> To: John Baldwin <jhb@freebsd.org> Cc: current@freebsd.org, Peter Jeremy <peterjeremy@optushome.com.au>, sparc64@freebsd.org, FreeBSD Tinderbox <tinderbox@freebsd.org>, John Birrell <jb@what-creek.com>, freebsd-sparc64@freebsd.org Subject: Re: [head tinderbox] failure on sparc64/sun4v Message-ID: <4550C463.4020502@cisco.com> In-Reply-To: <200611071011.15597.jhb@freebsd.org> References: <20061104060421.6145773068@freebsd-current.sentex.ca> <200611061649.56193.jhb@freebsd.org> <454FD0CF.4030705@cisco.com> <200611071011.15597.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin wrote: > > What I mean there is that there is a simple refcount_*() API wrapper in > sys/refcount.h that uses atomic ops on ints to safely manage reference > counts, and I would prefer the code to use refcount_*() instead of > atomic_*() directly if it fits as atomics can be tricky to manage > sometimes. > I need to think on this a bit.. the code is common to several platforms.. and this will take a bit of fore-thought to make sure we get it right if we move to something else besides the atomic_xxxx ops. There are also some where we do similar things to what the mbuf cluster freeing does with atomic_cmpset... etc. Simple refcnt's won't help there.. there are others that are not so... let me look through the macro's and see what I can come up with :-) R -- Randall Stewart NSSTG - Cisco Systems Inc. 803-345-0369 <or> 803-317-4952 (cell)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4550C463.4020502>