From owner-svn-src-all@freebsd.org Tue Aug 23 22:51:07 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 987A1BC4F13 for ; Tue, 23 Aug 2016 22:51:07 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: from mail-lf0-f46.google.com (mail-lf0-f46.google.com [209.85.215.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 215661626 for ; Tue, 23 Aug 2016 22:51:06 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: by mail-lf0-f46.google.com with SMTP id g62so110990280lfe.3 for ; Tue, 23 Aug 2016 15:51:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to; bh=2eI7Nb2lHaDWMUclVX7Vcjg/07CqUq66KNJlZh2XefY=; b=RJxSMcfqVkr07SKRCI0qXD0SPLHXGtFe5s5metkm/efuD6xXYMAUVXz+cd2kwp6KGW VQW4qTH50b1OeYFYB2/g/j30oeiXtW+RFqp194fSBv3dPIzeKKqzD3hB9ujvd3Si6Ylm W2YVVPl3Ysv4oX2XwHV5eKaNc1CUcw3sBIz7Wv6OtrVTnLu2V6gn/xNiLB5K15yqMZ6S 4voLOU21XFNfG/BRKTb3g8daEJ7Iw2d8BtLY4jBBLExr07VcI1vFSDVo4oKbezoghqrf wJTxGiT3eh/kIBU84+N3h400AJq1siu/6D3jdRocHBCoPxQvSmvZnEvbIlNAxHsMD95u tfmg== X-Gm-Message-State: AEkoousIFJtIxsbnGSK9e/iPPztrVJMYHnFAoG5svrE7ONhQ5qePlc1+Os2ygwccCY/QHg== X-Received: by 10.46.33.84 with SMTP id h81mr6907549ljh.47.1471986862688; Tue, 23 Aug 2016 14:14:22 -0700 (PDT) Received: from [192.168.1.2] ([89.169.173.68]) by smtp.gmail.com with ESMTPSA id e79sm1231788lji.42.2016.08.23.14.14.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Aug 2016 14:14:22 -0700 (PDT) Subject: Re: svn commit: r304703 - head/include/xlocale To: "Ngie Cooper (yaneurabeya)" References: <201608232033.u7NKXuZ9054093@repo.freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Andrey Chernov Message-ID: <48795833-b3ec-6cc3-1432-5669cc995b47@freebsd.org> Date: Wed, 24 Aug 2016 00:14:20 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="unTFewBggW3AsdvIf70LEhoQEkkHPSfmT" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Aug 2016 22:51:07 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --unTFewBggW3AsdvIf70LEhoQEkkHPSfmT Content-Type: multipart/mixed; boundary="CxCUBWbJ5Na6DlBvKS8J3p2PXXnIGAT0Q"; protected-headers="v1" From: Andrey Chernov To: "Ngie Cooper (yaneurabeya)" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <48795833-b3ec-6cc3-1432-5669cc995b47@freebsd.org> Subject: Re: svn commit: r304703 - head/include/xlocale References: <201608232033.u7NKXuZ9054093@repo.freebsd.org> In-Reply-To: --CxCUBWbJ5Na6DlBvKS8J3p2PXXnIGAT0Q Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 23.08.2016 23:53, Ngie Cooper (yaneurabeya) wrote: >=20 >> On Aug 23, 2016, at 13:33, Andrey A. Chernov wrote:= >> >> Author: ache >> Date: Tue Aug 23 20:33:56 2016 >> New Revision: 304703 >> URL: https://svnweb.freebsd.org/changeset/base/304703 >> >> Log: >> LC_*_MASK bit shifting order was partially broken from the initial co= mmit >> time at year 2012. Only LC_COLLATE_MASK and LC_CTYPE_MASK are in the >> right order. >> >> The order here should match XLC_* from "xlocale_private.h" which, in = turn, >> match LC_* publicly visible order from which determines ho= w >> locale components are stored in the structure. >> LC_*_MASK -> XLC_* translation done as "ffs(mask) - 1" in the querylo= cale() >> and equivalent shift loop in the newlocale(), so mapped to some wrong= >> components (excluding two mentioned above). >> >> Formally the fix is ABI breakage, but old code using those masks >> never works properly in any case. >> Only newlocale() and querylocale() are affected. >> >> MFC after: 7 days >> >> Modified: >> head/include/xlocale/_locale.h >=20 > Should __FreeBSD_version be bumped? > Thanks, > -Ngie >=20 Yes, I'll do it later. --CxCUBWbJ5Na6DlBvKS8J3p2PXXnIGAT0Q-- --unTFewBggW3AsdvIf70LEhoQEkkHPSfmT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBCAAGBQJXvLytAAoJEKUckv0MjfbKmMMIANIgBjua3n8uamBMzK00vhfO PfwQ/J8Ixgq90bPSyQeaR1s8mj506XG1YJG0jGIWq3/7vZaZK8nAoJUU+Imnx/sD h81zyGSU+FNInCD9SJTEws/w5dfMQxLT2E8JOJcThB81S3kURBePLCvyFaS3wVrn KisqitzNA3Oy78h3uQnFkI0PC3CH17kUlOKBX/0HMCEI7+ehiKgEtMwRQs+/tKyR R5sHE/rjj/5Dpj5UVkEqOW3IfuIhMS2yUF6J+LnlAheQjnBPKzjqV+Gmv/illAp1 taOxzBzI4L8n6o469rZzwZbh5E6WBCA1tG1h8ElOfwsv0FN9wy77/pv4PcWoWFA= =rYQ/ -----END PGP SIGNATURE----- --unTFewBggW3AsdvIf70LEhoQEkkHPSfmT--