From owner-svn-src-head@freebsd.org  Wed Aug 15 00:15:41 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1FE77106B2DA;
 Wed, 15 Aug 2018 00:15:41 +0000 (UTC) (envelope-from imp@FreeBSD.org)
Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org
 [IPv6:2610:1c1:1:606c::19:3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "mxrelay.nyi.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id BC0188F5A8;
 Wed, 15 Aug 2018 00:15:40 +0000 (UTC) (envelope-from imp@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 98AFC22C4A;
 Wed, 15 Aug 2018 00:15:40 +0000 (UTC) (envelope-from imp@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id w7F0FeqI029007;
 Wed, 15 Aug 2018 00:15:40 GMT (envelope-from imp@FreeBSD.org)
Received: (from imp@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id w7F0Fe9W029006;
 Wed, 15 Aug 2018 00:15:40 GMT (envelope-from imp@FreeBSD.org)
Message-Id: <201808150015.w7F0Fe9W029006@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: imp set sender to imp@FreeBSD.org
 using -f
From: Warner Losh <imp@FreeBSD.org>
Date: Wed, 15 Aug 2018 00:15:40 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r337824 - head/sys/cam
X-SVN-Group: head
X-SVN-Commit-Author: imp
X-SVN-Commit-Paths: head/sys/cam
X-SVN-Commit-Revision: 337824
X-SVN-Commit-Repository: base
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Aug 2018 00:15:41 -0000

Author: imp
Date: Wed Aug 15 00:15:40 2018
New Revision: 337824
URL: https://svnweb.freebsd.org/changeset/base/337824

Log:
  Flesh out a comment about what we're doing with read bias and trims.
  
  Sponsored by: Netflix

Modified:
  head/sys/cam/cam_iosched.c

Modified: head/sys/cam/cam_iosched.c
==============================================================================
--- head/sys/cam/cam_iosched.c	Tue Aug 14 22:57:28 2018	(r337823)
+++ head/sys/cam/cam_iosched.c	Wed Aug 15 00:15:40 2018	(r337824)
@@ -1311,7 +1311,9 @@ cam_iosched_get_trim(struct cam_iosched_softc *isc)
 	if (do_dynamic_iosched) {
 		/*
 		 * If pending read, prefer that based on current read bias
-		 * setting.
+		 * setting. The read bias is shared for both writes and
+		 * TRIMs, but on TRIMs the bias is for a combined TRIM
+		 * not a single TRIM request that's come in.
 		 */
 		if (bioq_first(&isc->bio_queue) && isc->current_read_bias) {
 			isc->current_read_bias--;