From owner-svn-src-all@FreeBSD.ORG  Thu Aug 19 14:51:39 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id ECBE21065673;
	Thu, 19 Aug 2010 14:51:39 +0000 (UTC)
	(envelope-from asmrookie@gmail.com)
Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com
	[209.85.216.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 722538FC18;
	Thu, 19 Aug 2010 14:51:39 +0000 (UTC)
Received: by qwg5 with SMTP id 5so2026782qwg.13
	for <multiple recipients>; Thu, 19 Aug 2010 07:51:38 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:mime-version:received:sender:received
	:in-reply-to:references:date:x-google-sender-auth:message-id:subject
	:from:to:cc:content-type:content-transfer-encoding;
	bh=XvUsSuZ2XHstwfX220r3SqCle4OGvHMyFrKgdyRqSHM=;
	b=Eo3B5e8wiVsjZ3P9At/LqRh56aCgjlgAmTHh56J6YpnrNaZ4SpyUIc1Vu3rKUa/4EW
	N+yIwECToTOtKSPOmnHN08V5+5TQNVY4dVwIaekV6bLblDP1I5HaGHD+9xR3NAKhuW1Q
	hKHpdSHpu8zsXIEbm6sdSsKFHK0cej4D0Y7v4=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type
	:content-transfer-encoding;
	b=CBkhlmpMWrF4Vpt4/G7RSyPHCmLhCdqZDlG6LA/Q3uU+WUkxvrSSZHO2wBb9EqM5s+
	yk1nKSZWxbhaNuRCj4xtDqVIs++gijg9FJKgqEc1QOCuXjGnKGxiNUaYm13sK72o+wgF
	ZnilqcLPJI7OJdvJr6w3a869x7lkKLT5PmPxM=
MIME-Version: 1.0
Received: by 10.229.227.210 with SMTP id jb18mr7400986qcb.93.1282229497809;
	Thu, 19 Aug 2010 07:51:37 -0700 (PDT)
Sender: asmrookie@gmail.com
Received: by 10.229.251.6 with HTTP; Thu, 19 Aug 2010 07:51:37 -0700 (PDT)
In-Reply-To: <8662z6r77w.fsf@ds4.des.no>
References: <201008161132.o7GBWKhx097183@svn.freebsd.org>
	<86mxsm4wff.fsf@ds4.des.no> <86bp924w3w.fsf@ds4.des.no>
	<AANLkTikVMVpM=E3x6i=zGnCqPrTis=kyA3PzhwotB=H0@mail.gmail.com>
	<8662z6r77w.fsf@ds4.des.no>
Date: Thu, 19 Aug 2010 16:51:37 +0200
X-Google-Sender-Auth: iSEprwKMxoC0vUMW3B3h5nfUTSc
Message-ID: <AANLkTi=vSxjTEToPyFZC_DwUPnTq4Sr-RoKRT7sJm+p=@mail.gmail.com>
From: Attilio Rao <attilio@freebsd.org>
To: =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= <des@des.no>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r211393 - head/lib/libutil
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Aug 2010 14:51:40 -0000

2010/8/19 Dag-Erling Sm=C3=B8rgrav <des@des.no>:
> Attilio Rao <attilio@freebsd.org> writes:
>> It seems to me that ftpd doesn't need any change, do you agree?
>
> Hmm, it never calls setuid(), but it does call seteuid() before
> setusercontext(). =C2=A0Perhaps the test in setusercontext() should be
> changed to use geteuid() instead of getuid().

Yes, I think that it probabilly makes more sense (geteuid() testing in
setusercontext()).

Thanks,
Attilio


--=20
Peace can only be achieved by understanding - A. Einstein