Date: Wed, 7 Jul 2004 22:41:15 -0400 (EDT) From: Joe Talbott <josepht@xenno.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/68796: [patch] IceWM fix focusing new+maximized windows Message-ID: <200407080241.i682fFjW054826@jupiter.xenno.com> Resent-Message-ID: <200407080250.i682oNbn049585@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 68796
>Category: ports
>Synopsis: [patch] IceWM fix focusing new+maximized windows
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Thu Jul 08 02:50:22 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator: Joe Talbott
>Release: FreeBSD 4.10-STABLE i386
>Organization:
none
>Environment:
System: FreeBSD localhost 4.10-STABLE FreeBSD 4.10-STABLE #26: Wed Jun 16 15:26:18 EDT 2004 root@localhost:/usr/obj/usr/src/sys/JUPITER i386
icewm-1.2.14 (x11-wm/icewm)
>Description:
Applications like Mozilla or Firefox that I open maximized don't are raised to the top but don't get focus.
>How-To-Repeat:
Open Mozilla or Firefox maximized.
>Fix:
--- wmmgr.cc.patch begins here ---
--- wmmgr.cc Sun May 23 02:18:19 2004
+++ wmmgr.cc.new Wed Jul 7 15:58:53 2004
@@ -1489,10 +1489,11 @@
canManualPlace = true;
if (mapClient) {
- if (frame->getState() == 0 || frame->isRollup()) {
+ if (!(frame->getState() & (WinStateHidden | WinStateMinimized | WinStateFullscreen)))
+ {
if (canManualPlace && !opaqueMove)
frame->manualPlace();
- }
+ }
}
frame->updateState();
frame->updateProperties();
@@ -1504,7 +1505,8 @@
if (frame->affectsWorkArea())
updateWorkArea();
if (mapClient) {
- if (frame->getState() == 0 || frame->isRollup()) {
+ if (!(frame->getState() & (WinStateHidden | WinStateMinimized)))
+ {
if (wmState() == wmRUNNING && canActivate)
frame->focusOnMap();
if (canManualPlace && opaqueMove)
--- wmmgr.cc.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200407080241.i682fFjW054826>