From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Jul 8 02:50:23 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5588C16A4CF for ; Thu, 8 Jul 2004 02:50:23 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2FAC943D5D for ; Thu, 8 Jul 2004 02:50:23 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i682oNYY049586 for ; Thu, 8 Jul 2004 02:50:23 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i682oNbn049585; Thu, 8 Jul 2004 02:50:23 GMT (envelope-from gnats) Resent-Date: Thu, 8 Jul 2004 02:50:23 GMT Resent-Message-Id: <200407080250.i682oNbn049585@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Joe Talbott Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CB98716A4CE for ; Thu, 8 Jul 2004 02:41:17 +0000 (GMT) Received: from jupiter.xenno.com (jupiter.xenno.com [216.12.87.49]) by mx1.FreeBSD.org (Postfix) with ESMTP id 686C743D49 for ; Thu, 8 Jul 2004 02:41:17 +0000 (GMT) (envelope-from josepht@jupiter.xenno.com) Received: from jupiter.xenno.com (localhost [127.0.0.1]) by jupiter.xenno.com (8.12.11/8.12.11) with ESMTP id i682fGv2054827 for ; Wed, 7 Jul 2004 22:41:16 -0400 (EDT) (envelope-from josepht@jupiter.xenno.com) Received: (from josepht@localhost) by jupiter.xenno.com (8.12.11/8.12.11/Submit) id i682fFjW054826; Wed, 7 Jul 2004 22:41:15 -0400 (EDT) (envelope-from josepht) Message-Id: <200407080241.i682fFjW054826@jupiter.xenno.com> Date: Wed, 7 Jul 2004 22:41:15 -0400 (EDT) From: Joe Talbott To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: ports/68796: [patch] IceWM fix focusing new+maximized windows X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Joe Talbott List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Jul 2004 02:50:23 -0000 >Number: 68796 >Category: ports >Synopsis: [patch] IceWM fix focusing new+maximized windows >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Jul 08 02:50:22 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Joe Talbott >Release: FreeBSD 4.10-STABLE i386 >Organization: none >Environment: System: FreeBSD localhost 4.10-STABLE FreeBSD 4.10-STABLE #26: Wed Jun 16 15:26:18 EDT 2004 root@localhost:/usr/obj/usr/src/sys/JUPITER i386 icewm-1.2.14 (x11-wm/icewm) >Description: Applications like Mozilla or Firefox that I open maximized don't are raised to the top but don't get focus. >How-To-Repeat: Open Mozilla or Firefox maximized. >Fix: --- wmmgr.cc.patch begins here --- --- wmmgr.cc Sun May 23 02:18:19 2004 +++ wmmgr.cc.new Wed Jul 7 15:58:53 2004 @@ -1489,10 +1489,11 @@ canManualPlace = true; if (mapClient) { - if (frame->getState() == 0 || frame->isRollup()) { + if (!(frame->getState() & (WinStateHidden | WinStateMinimized | WinStateFullscreen))) + { if (canManualPlace && !opaqueMove) frame->manualPlace(); - } + } } frame->updateState(); frame->updateProperties(); @@ -1504,7 +1505,8 @@ if (frame->affectsWorkArea()) updateWorkArea(); if (mapClient) { - if (frame->getState() == 0 || frame->isRollup()) { + if (!(frame->getState() & (WinStateHidden | WinStateMinimized))) + { if (wmState() == wmRUNNING && canActivate) frame->focusOnMap(); if (canManualPlace && opaqueMove) --- wmmgr.cc.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: