Date: Sun, 25 Oct 2020 13:14:22 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: Ed Maste <emaste@freebsd.org>, Warner Losh <imp@bsdimp.com> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r366993 - head/sys/net Message-ID: <7d769528-9c00-7096-11f3-4bcd751dcb05@FreeBSD.org> In-Reply-To: <CAPyFy2Coiyz1CYGGLD3QS1M-6Q4Hc38WNcXA%2BKvRbuTAhmMvcA@mail.gmail.com> References: <202010241023.09OANMcL075640@repo.freebsd.org> <20201024125206.GB38000@FreeBSD.org> <999a005e-1ef8-3c45-fb07-94a3b6ebce1b@selasky.org> <317231603546378@mail.yandex.ru> <CANCZdfq8NH=rspaugts=W0Uu183pDcVvOK8oGh6kCvfpkM-=Ww@mail.gmail.com> <CAPyFy2Coiyz1CYGGLD3QS1M-6Q4Hc38WNcXA%2BKvRbuTAhmMvcA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10/24/20 8:19 PM, Ed Maste wrote: > On Sat, 24 Oct 2020 at 11:27, Warner Losh <imp@bsdimp.com> wrote: >>> Given we already have nice .clang-format, that does most of the job, maybe it's worth considering looking into tweaking it further to fix this part? >>> It would be nice if we could finally offload all formatting issues to the tool and focus on the actual code :-) >> It would be nice if it produced one of the style(9) acceptable formats without disrupting things already acceptable. That's been the big problem with the tweaks to date... some things are fixed, others break. It's getting a lot closer, though > Upstream clang-format comes with a script that can integrate with git, > adding a `git clang-format` command. It will apply formatting to > modified lines, leaving unchanged ones alone. I doubt any script can match style(9) perfectly. indent(1) with bde's flags came near in some edge cases but generally did a horrible job. Also, out style(9) is not mandatory for userland. Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7d769528-9c00-7096-11f3-4bcd751dcb05>