From owner-freebsd-current Sat Dec 19 16:19:00 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id QAA09120 for freebsd-current-outgoing; Sat, 19 Dec 1998 16:19:00 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from alpo.whistle.com (alpo.whistle.com [207.76.204.38]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id QAA09087; Sat, 19 Dec 1998 16:18:12 -0800 (PST) (envelope-from julian@whistle.com) Received: (from daemon@localhost) by alpo.whistle.com (8.8.5/8.8.5) id QAA15897; Sat, 19 Dec 1998 16:13:27 -0800 (PST) Received: from current1.whistle.com(207.76.205.22) via SMTP by alpo.whistle.com, id smtpdH15895; Sun Dec 20 00:13:21 1998 Date: Sat, 19 Dec 1998 16:13:18 -0800 (PST) From: Julian Elischer To: current@FreeBSD.ORG cc: core@FreeBSD.ORG Subject: Appologies about commit screwup Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG I was trying SO HARD to get it right that I stuffed it in the other direction.. In the last moment after testing, I reapplied a patch to a file because I had accidentally dropped editor cruft into the patched version. I was tired and in a hurry (I was late for an appointment) and stupidly used the -D option for patch. This inserted cpp condidionals into the file where they didn't work. The reason I decided to add the -D argument is probably due to lack of sleep because I wanted to have the code be the same after the patch if teh conditional is not defined on. For complete stupidity, that goes pretty far as an example.. and then to make matters worse, I recompiled the wrong kernel to test it and got the one that didn't include the file in question. remember kids, recompile LINT, not GENERICX!!!! SOS's fix is correct and reflects the file in my original test tree almost down to the added comments on the #endif lines All I can say is "I screwed up and deserve the pointy stick" pointy hat optional.. lessons "Don't commit when in a hurry to leave" "If you fix a screwup, restart all your testing from the beginning rather than try 'shortcut' it" "Don't commit when you are to tired to think straight" "Don't trust patch -D.. always inspect the results" Considering how much I didn't want to screw up this one it's really quite amazing how much it was screwed up. julian To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message