From owner-svn-src-head@freebsd.org Wed Nov 11 19:29:14 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 03F28A2B4DE; Wed, 11 Nov 2015 19:29:14 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-ig0-x234.google.com (mail-ig0-x234.google.com [IPv6:2607:f8b0:4001:c05::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BDF7B188D; Wed, 11 Nov 2015 19:29:13 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by igcph11 with SMTP id ph11so78950443igc.1; Wed, 11 Nov 2015 11:29:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=DVU6sV+SXfhQNhvOc5qcWUaO9IambrtXEwCEGOPiEvA=; b=uAYSrfd6nAW+k4O6Td6yPqcWYRv7mB6i1U8Kc9f3GEzbP6Yl/mbS5d9w+JhxZc6L4G rk3I2lrq5Ie7QwA9b3BCYL74t2fIPKnb6syW8NLy9IZtupHDrT+qft2/k2jLP4dN9Vhg orwEXsVruVj/TE/tFowkMNvNXqL9qtcZTfvH0OCxS93cCYRPXpnx3aYphqVwdYmXHD/f pPBIm/C0k4uIH8Tj65nFq7YwuhmDaIyEzggjHnZ08fyx2ygEQDTSx7jNDRVssPD1sIN7 8XTY34+nWrVbKwXDX72c2AmMOrRtiATt/kzgj2ILcvUzt8/9QFa2oKnFmmLWEnmPkB7l 2v3Q== X-Received: by 10.50.225.102 with SMTP id rj6mr34473456igc.95.1447270152801; Wed, 11 Nov 2015 11:29:12 -0800 (PST) Received: from [22.35.181.205] ([172.56.9.126]) by smtp.gmail.com with ESMTPSA id np7sm16342igb.0.2015.11.11.11.29.11 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 11 Nov 2015 11:29:12 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r290663 - in head/sys: modules modules/tests modules/tests/callout_test modules/tests/framework tests tests/callout_test tests/framework From: Garrett Cooper X-Mailer: iPhone Mail (13B143) In-Reply-To: <201511101414.tAAEEfPI057133@repo.freebsd.org> Date: Wed, 11 Nov 2015 11:29:11 -0800 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <8B50A504-D6A9-49CF-917C-50F667A217A8@gmail.com> References: <201511101414.tAAEEfPI057133@repo.freebsd.org> To: Randall Stewart X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Nov 2015 19:29:14 -0000 > On Nov 10, 2015, at 06:14, Randall Stewart wrote: >=20 > Author: rrs > Date: Tue Nov 10 14:14:41 2015 > New Revision: 290663 > URL: https://svnweb.freebsd.org/changeset/base/290663 >=20 > Log: > Add a kernel test framework. The callout_test is a demonstration and will= only > work with the upcoming async-drain functionality. Tests can be added > to the tests directory and then the framework can be used to launch > those tests. >=20 > MFC after: 1 month > Sponsored by: Netflix Inc. > Differential Revision: https://reviews.freebsd.org/D1755 Hi Randall, This code drop is lacking a few things: 1. How can other consumers use this? 2. How does this hook in to ATF/Kyua or Jenkins? There are a bunch of style bugs in the code as well. It seems like based on the lack of documentation, this needed more revie= w/communication and probably should have been put in share/examples or tools= /test until it could be integrated into existing frameworks and used by ever= yone else. Thank you, -NGie