From owner-cvs-all@FreeBSD.ORG Wed Nov 2 15:23:51 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A110C16A41F; Wed, 2 Nov 2005 15:23:51 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D77A343D77; Wed, 2 Nov 2005 15:23:47 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id jA2FNluD083192; Wed, 2 Nov 2005 15:23:47 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id jA2FNlxf083191; Wed, 2 Nov 2005 15:23:47 GMT (envelope-from glebius) Message-Id: <200511021523.jA2FNlxf083191@repoman.freebsd.org> From: Gleb Smirnoff Date: Wed, 2 Nov 2005 15:23:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netgraph ng_base.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Nov 2005 15:23:51 -0000 glebius 2005-11-02 15:23:47 UTC FreeBSD src repository Modified files: sys/netgraph ng_base.c Log: Fix two races which happen when netgraph is restructuring: - Introduce ng_topo_mtx, a mutex to protect topology changes. - In ng_destroy_node() protect with ng_topo_mtx the process of checking and pointing at ng_deadnode. [1] - In ng_con_part2() check that our peer is not a ng_deadnode, and protect the check with ng_topo_mtx. - Add KASSERTs to ng_acquire_read/write, to make more understandible synopsis in case if called on ng_deadnode. Reported by: Roselyn Lee [1] Revision Changes Path 1.117 +47 -8 src/sys/netgraph/ng_base.c