From nobody Thu Jan 4 09:35:39 2024 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T5M0H6wwXz56BqX for ; Thu, 4 Jan 2024 09:35:59 +0000 (UTC) (envelope-from junchoon@dec.sakura.ne.jp) Received: from www121.sakura.ne.jp (www121.sakura.ne.jp [153.125.133.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4T5M0H1WQbz4pG5; Thu, 4 Jan 2024 09:35:58 +0000 (UTC) (envelope-from junchoon@dec.sakura.ne.jp) Authentication-Results: mx1.freebsd.org; none Received: from kalamity.joker.local (123-1-22-158.area1b.commufa.jp [123.1.22.158]) (authenticated bits=0) by www121.sakura.ne.jp (8.17.1/8.17.1/[SAKURA-WEB]/20201212) with ESMTPA id 4049ZdVe087169; Thu, 4 Jan 2024 18:35:40 +0900 (JST) (envelope-from junchoon@dec.sakura.ne.jp) Date: Thu, 4 Jan 2024 18:35:39 +0900 From: Tomoaki AOKI To: Brooks Davis Cc: Bakul Shah , Jamie Landeg-Jones , FreeBSD Current , yuri@freebsd.org Subject: Re: git repo port issues? Message-Id: <20240104183539.cef54811b98fe53c5841edca@dec.sakura.ne.jp> In-Reply-To: References: <202401031913.403JDZBt028036@donotpassgo.dyslexicfish.net> <46C8698A-A004-4B5F-9107-6D9FD3685074@iitbombay.org> Organization: Junchoon corps X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4T5M0H1WQbz4pG5 X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:7684, ipnet:153.125.128.0/18, country:JP] On Wed, 3 Jan 2024 23:32:27 +0000 Brooks Davis wrote: > On Wed, Jan 03, 2024 at 03:09:15PM -0800, Bakul Shah wrote: > > On Jan 3, 2024, at 11:22???AM, Brooks Davis wrote: > > > > > > Nothing about dates is centralized in git, but some server side checks > > > could be implemented on CommitDate. IMO we should require that > > > CommitDate be >= the previous one and less than "now". > > > > Given that git commit objects form a DAG, I don't see how you can > > impose linearity. > > Check each commit in a push to ensure that its CommitDate is newer than > its first parent's CommitDate (you could check them all, but as a > project we're mostly linear). Seems like a pretty trivial property to > enforce. > > -- Brooks Or create database (key-value store would be sufficient) storing commit order (like r* of svn) and commit hash. I'm still not certain whether commit order or commit hash should be the "key". Possibly store hash as the key fisrt and store assigned MONOTONIC order as value, then, add the just-stored order as key and hash as value in another database would be neeed. If the database can contain 2 value for 1 key, it would be suitable for you to store the assigned time in UTC as "when it is committed to FreeBSD master repo". Just a thought. Regards. -- Tomoaki AOKI