From owner-svn-src-all@freebsd.org Thu Sep 17 14:12:14 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 61A9E9CE205 for ; Thu, 17 Sep 2015 14:12:14 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk0-f179.google.com (mail-qk0-f179.google.com [209.85.220.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2177D12C5 for ; Thu, 17 Sep 2015 14:12:13 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by qkap81 with SMTP id p81so6859097qka.2 for ; Thu, 17 Sep 2015 07:12:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=yJ8NzwjGuf9B8FyVtMyTvkg4pJTgFEaps39Se90A088=; b=W5644meWuvTlvAdSi57UzTqtJ6ocDiT/cTTKrtgoalUzNtQcHUT99te+z/6NRdDz3Q UKo1ZziDDhD5gx6Sfkq050Ww6MFQb/wGB9sv4oFmXMqX790JNubwqZNFEHsdjgaNFLL1 5MPCc8cRBrwA//pCpoJWGVIvkO5YZC68Bp2n0PeIFVN8sIX6UXC0NmLugTX2XRGRw8c6 8h7n1mITTKeqnRxXk/TIHlTZjUG5bSLI3mcGkC2b9CKGO+hZbw+bwLw2Guq4y/x6USlp tymOzhjVHGCmi58ruj3cwjv6YYQDnsyEi1UYtsweuK3SqthC/sl7PnVt5yL06hh70jZ1 CT6Q== X-Gm-Message-State: ALoCoQlvCCzjuuHFRtmwRQKpjuhlzTubv56wl4wTztFIqDVabEsduWzYgR6wERZ6exfXZERR3/mU MIME-Version: 1.0 X-Received: by 10.55.204.208 with SMTP id n77mr51400912qkl.46.1442499127389; Thu, 17 Sep 2015 07:12:07 -0700 (PDT) Sender: wlosh@bsdimp.com Received: by 10.140.80.167 with HTTP; Thu, 17 Sep 2015 07:12:07 -0700 (PDT) X-Originating-IP: [50.253.99.174] In-Reply-To: <55FA8A3F.4000005@selasky.org> References: <201509141052.t8EAqRWf008293@repo.freebsd.org> <20150916220559.GS1023@FreeBSD.org> <55FA69BD.10507@selasky.org> <0952027A-5276-487D-99B8-74747B0EEF5D@FreeBSD.org> <55FA8A3F.4000005@selasky.org> Date: Thu, 17 Sep 2015 08:12:07 -0600 X-Google-Sender-Auth: GnahNSeOPiUrJuahbUlwhKU8j3E Message-ID: Subject: Re: svn commit: r287780 - in head: share/man/man9 sys/kern sys/sys From: Warner Losh To: Hans Petter Selasky Cc: David Chisnall , Gleb Smirnoff , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Sep 2015 14:12:14 -0000 Hi Hans, Given how contentious this has been in the past, perhaps it would be better to goad people like rrs@ into giving you a positive, explicit OK rather than relying on a timeout that may not indicate that your change is good, just that your reviewers are busy. Warner On Thu, Sep 17, 2015 at 3:39 AM, Hans Petter Selasky wrote: > On 09/17/15 11:07, David Chisnall wrote: > >> On 17 Sep 2015, at 08:20, Hans Petter Selasky wrote: >> >>> >>> On 09/17/15 00:05, Gleb Smirnoff wrote: >>> >>>> Weren't you explicitly asked not to touch this system without a proper >>>> review and discussion? >>>> >>> >>> Adding a new function is not touching code. >>> >> >> Adding a new interface to an existing core subsystem is most definitely >> touching the system. I would expect *anyone* making a change like this t= o >> have both the design and code reviewed for sanity checking. >> > > For someone who has already been required to have explicit review of an= y > changes to the subsystem to skip this step shows a flagrant disregard for > the project=E2=80=99s policies and best practices. > > David, > > My patch is _not_ touching the existing callout system. It's touching the > callout API. Maybe my understanding of touching is different than yours. > You can voice your conserns in phabricator please, isn't that why we have > Phabricator? > > https://reviews.freebsd.org/D3521 > > The differential review has been out for 14 days with relevant people lik= e > rss on the reviewers list, and no conserns were raised. Only manual page > comments from wblock, and those were addressed. I will refer to a well > known saying, that whoever tier agree. It is a bit late to shout now. > > David, I think phabricator allows filtering so that all commits which > touch sys/kern gets your subscription. At least wblock was automatically > subscribed because of updating some manual pages. I think that's the way = to > go. > > Let's end this discussion here and move it somewhere else. > > --HPS > > >