Date: Tue, 23 Jan 2018 15:47:43 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: Alex Dupre <ale@FreeBSD.org> Cc: Alexey Dokuchaev <danfe@FreeBSD.org>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r459751 - in head/lang: . solidity solidity/files Message-ID: <20180123144743.scc42sitwjhvxspv@aragorn.in.absolight.net> In-Reply-To: <57ffd7bd-6a3f-b315-b582-17d9dccee5a8@FreeBSD.org> References: <201801231358.w0NDwMa8074241@repo.freebsd.org> <20180123140938.GA73049@FreeBSD.org> <57ffd7bd-6a3f-b315-b582-17d9dccee5a8@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--755f4kp4bfgi6t6n Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 23, 2018 at 03:31:03PM +0100, Alex Dupre wrote: > Alexey Dokuchaev wrote: > > On Tue, Jan 23, 2018 at 01:58:22PM +0000, Alex Dupre wrote: > >> New Revision: 459751 > >> URL: https://svnweb.freebsd.org/changeset/ports/459751 > >> > >> Log: > >> The Solidity Contract-Oriented Programming Language > >> =20 > >> WWW: https://github.com/ethereum/solidity > >> > >> Added: head/lang/solidity/Makefile > >> ... >=20 > Hi Alexey, I often agree with your comments, but this time I have to > strongly disagree. >=20 > % portlint -tac solidity/ > looks fine. >=20 > >> +COMMENT=3D Solidity Contract-Oriented Programming Language > >=20 > > COMMENT=3D Contract-oriented programming language >=20 > Come on, then the comment for the scala port should be "Programming > Language"? >=20 > >=20 > >> +OPTIONS_DEFINE=3D SMT > >> +SMT_DESC=3D SMT Checker > >> +SMT_LIB_DEPENDS=3Dlibz3.so:math/z3 > >> + > >> +USES=3D cmake > >=20 > > Misplaced USES. >=20 > I don't see what's misplaced here, portlint doesn't seem to agree with yo= u. portlint is a third party static lint tool, it does not understand what you does, it just tells you when it is very very bad (when it does not get it wrong.) https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html > >> +CMAKE_ARGS+=3D -DUSE_LD_GOLD=3DOFF -DTESTS=3DOFF \ > >> + -DJSONCPP_INCLUDE_DIR:STRING=3D"${LOCALBASE}/include/jsoncpp" \ > >> + -DJSONCPP_LIB_DIR:STRING=3D"${LOCALBASE}/lib" > >=20 > > And CMAKE_ARGS (also bogus +=3D). >=20 > Really? >=20 > >> +pre-patch: > >> + @${CP} ${FILESDIR}/jsoncpp.cmake ${WRKSRC}/cmake/ > >> + @${REINPLACE_CMD} '/EthCcache/d' ${WRKSRC}/CMakeLists.txt > >=20 > > Excessive indentation of target recipe (commands). >=20 > Seriously? >=20 > >> Added: head/lang/solidity/pkg-descr > >> ... > >> @@ -0,0 +1,3 @@ > >> +The Solidity Contract-Oriented Programming Language > >> + > >> +WWW: https://github.com/ethereum/solidity > >=20 > > Bad port description (verbatim copy of COMMENT), tells nothing about the > > port (violation of PHB Section 3.2.1). > This is the only thing I agree on, changed. >=20 > --=20 > Alex Dupre >=20 >=20 --755f4kp4bfgi6t6n Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAlpnSw5fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkiGJg//YaUWtWHK9BVS6fkFIkEwO0yGRmfkXiVzHoLASP9J3ClNqh820RUgKK6J 10YkWNlR9EmlfUZozqewIf4A0hCI2b0qU7IkNoQQyQ7to9k31PjB3pU11luXoPKz aW8KScHBBhalqXbJTZ7ldSWNDqxvS67JQh+Ybqz2uUKXoeozVxm5pU3qUac35xN+ uhd6OkTWLtU60CIq71rmXrWAGz7SkArSxMCdQaN1tTb6qrBljvPS1VGNVk6RMbbS 2zUCOQ5dLULVXBQ0K+mJVESOGjB0WeygKUQEOC5CWd0Z2Gr91/tk1WWSpKeBJipv JS99l9VDOKIkwA0ujk2EpzhamyK+W6IcecBqtUehiLPWk7B6/OLjziK8a7ihawMA K7SQAyIFqK4MijAWW4a1c6psQF0FQ44ZI/1piyPX6kmF+M0DC/iXtyd4jnhUaJRX 1bjBFpH1pJl/qGi81jdJ9FqI/ORtvPL3F5HeCWmmOMSxTTzrW/66L840l4P7txmp X/ooB2HDVJ4we0OfOAcSAyyB5y0botl8R7QgkcsZXzu5pKfP8dKYEV+uEJQ0OgKO 3o0Td+1a6wJ3B1SSQhxSJW7SY3yVaACT7SWzYgjzZi/Ky5288HC1vbqVCvjcDZ1n MsYRVelC+OjEskV+k7vmwgF4l9MENUNg5xawostP1L4aR0XvFUY= =htnA -----END PGP SIGNATURE----- --755f4kp4bfgi6t6n--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180123144743.scc42sitwjhvxspv>