From owner-svn-src-head@freebsd.org Sat Dec 30 16:04:08 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1E4EDE9F698 for ; Sat, 30 Dec 2017 16:04:08 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from sonic312-36.consmr.mail.ne1.yahoo.com (sonic312-36.consmr.mail.ne1.yahoo.com [66.163.191.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E540516BC for ; Sat, 30 Dec 2017 16:04:07 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1514649841; bh=fR3yQ3vX3zqPxW4btIg1aAKnEkiccNW9F1lrZPqLkEQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From:Subject; b=VKUxgSQSRuImP5Q5O7kI7khJ9xwU6WVG/YJ1sB46XspKMYp3VNz5Ap4JvLgU5NlFO7XOHuK+6/HnZyzTFHlaJpSTTeJY2dg+U6nDO97dmqOOJMLNCvPQ9A20rQK0eBpVN2mcHg1vDJbpsHdnw3lDVLInTysqDMMXxq3MIPFpZKRU5qCRiLdj3cJs7oP1FAtKZdzutm7fV4SLFkJhzzdNB/GFjZ0xgyzfceUzntJAr2tnGlBZ8/KJU4qgzjRKzVk0xsmdCylLdyOINPqEsYRxd6zOLaQrDG2A2AJ9wBXkz3zSyFqfB6BN7mMR15zfbnJWed7bEZODgnW10eViEqfz5A== X-YMail-OSG: dijbf90VM1lZeuPMw4fPIS6SsEMSvv.iO30l2SawINabZ66rnROhZ7KgkuaxYVg CFMQC8lajLsobBa9QVvZifO9nwZEb.seNz0mvMRzHhc0B1ajXFTX6Hx_4XEalGpiZ9DvIw6yzShx QrZ6HTVRTsqx8HZYvDnDQwHKaTi0BWOTwFNOIddU8VTIDHY2RV.49dW2DVONh4irlVoxDTJQTBH5 WXB0pTOLvC5cRXMwB959LAKCjwu9MAwKF33zFAwStIBs7ovlLLtOQzIP7FuOk92hNug57clYLMAm BpYdIS0htI.HggkBwUS6jKkFZ3qYO846Wrm_hkGLdw9dz7LG3EbWwvOBWTQJUwQoZNHGpIoEFRgp 3efH11iTLrFy8qaX9HozKCjiUGAt_pPBh8kGC0cNiH7HNk.XZO4ye2PMBPOeLFvVYdUF0ca9pP.z 525sFnpVjcAzavrKdF.ORKunPi2RtIgeIrPpzIi75C3UrIxHGGLbJS1pfLNrp6P.OQIZPWqFb Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ne1.yahoo.com with HTTP; Sat, 30 Dec 2017 16:04:01 +0000 Received: from smtp235.mail.ne1.yahoo.com (EHLO [192.168.0.6]) ([10.218.253.206]) by smtp409.mail.ne1.yahoo.com (JAMES SMTP Server ) with ESMTPA ID 4a761faf319ca71a8dd802b6b1079339; Sat, 30 Dec 2017 16:03:56 +0000 (UTC) Subject: Re: svn commit: r327368 - head/sbin/ccdconfig To: rgrimes@freebsd.org Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201712301511.vBUFBTM8076272@pdx.rh.CN85.dnsmgr.net> From: Pedro Giffuni Message-ID: <13e7d603-dc2f-2f74-90db-d0bf5059fabe@FreeBSD.org> Date: Sat, 30 Dec 2017 11:03:57 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <201712301511.vBUFBTM8076272@pdx.rh.CN85.dnsmgr.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Dec 2017 16:04:08 -0000 On 12/30/17 10:11, Rodney W. Grimes wrote: >> Author: pfg >> Date: Sat Dec 30 00:22:47 2017 >> New Revision: 327368 >> URL: https://svnweb.freebsd.org/changeset/base/327368 >> >> Log: >> ccdconfig: Update licensing terms to match NetBSD. >> >> The code originated in NetBSD which has since removed Clauses 3 and 4. >> >> Approved by: phk (concerning his own copyright) >> Obtained from: NetBSD (CVS ccdconfig.c 1.47, ccdconfig.8 1.24) > I am a bit on edge about these "license" changes that are occuring, > before what you had been doing was adding "SPDX" tags which are just > an advisory item, now your actually changing the text of licenses > and doing so without second or third eyes and in a way that for me > is a bit questionable. That is correct. I will be glad to move to "code review" mode from now on. I agree it is important to have more eyes on such changes. It just happens that even copyright owners sometimes don't want to look at these changes. > Part of the problem comes that if you go back and pull a licence change > from NetBSD that was done in 2000 and apply it to our code because it > was dervied from there your ignoring the fact that someone else may > of made changes between 2000 and today, and technically those changes > fall under the licence that was inplace when they made those changes. It is not as simple as that, I did check the changes that are relevant for us in NetBSD before the license changes. I might have missed something though, so yes I agree on having more eyes. > Also the NetBSD license change may of been athorized directly, as in > this case here where you got direct permission from phk, and I have not > seen any notes about that in your prior commits. Also note that if > someone authorized NetBSD to make a license change, that authorization > is NOT global in nature, it is for NetBSD to make that change, not > *BSD. Authorization from NetBSD would be necessary if we were including code from NetBSD that was not meant to be covered by the license change. I didn't find any evidence of that, but feel free to point out any such case so that we can take it to the NetBSD guys. Pedro.