From owner-svn-src-head@FreeBSD.ORG Sun Dec 14 09:08:10 2008 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A41A8106564A; Sun, 14 Dec 2008 09:08:10 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.230]) by mx1.freebsd.org (Postfix) with ESMTP id 636A08FC1A; Sun, 14 Dec 2008 09:08:10 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: by rv-out-0506.google.com with SMTP id b25so2237508rvf.43 for ; Sun, 14 Dec 2008 01:08:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=IIg5u38gBtlXLSbDqOs0Bqi2bTkurSu7sNJHUS2P6ZI=; b=A+ZHjMzFZbmVH/AMif+Cdh88hAanIGNdN14b/wzOQckb/DceUYpZflzaFXmds+/QDo l0l9buB9Yd5k4ebwWEIG4LHeGTgfdYJfl1X/KPscrMdehlZoVKP41J9I+GIsTZLtiroi pCLBRvSISexhCJv626A2HsQ6lX1GurnKfFOhw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=jLnX6TXjN2H5Ci9MDQ4jug3PnS8IBz52YDICPub+BNka8jhLZqH/13TmxfrjRutjr3 nHio2erhVbTmyzk8TQFQ7EPjXwr4GEskH5BzOC8kHneZHgULF7xToxteNDPlJg3JrY+9 7EIVD2ZEgQwV++SBsXE8Uo9Og5bY/N4Gm3vdA= Received: by 10.140.188.10 with SMTP id l10mr2980094rvf.94.1229245690197; Sun, 14 Dec 2008 01:08:10 -0800 (PST) Received: by 10.140.158.13 with HTTP; Sun, 14 Dec 2008 01:08:10 -0800 (PST) Message-ID: <7d6fde3d0812140108l4b0c75e1o229c667c0b86dd7e@mail.gmail.com> Date: Sun, 14 Dec 2008 01:08:10 -0800 From: "Garrett Cooper" To: "Joseph Koshy" In-Reply-To: <200812140906.mBE96SEZ054272@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200812140906.mBE96SEZ054272@svn.freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r186076 - head/sys/amd64/amd64 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Dec 2008 09:08:10 -0000 On Sun, Dec 14, 2008 at 1:06 AM, Joseph Koshy wrote: > Author: jkoshy > Date: Sun Dec 14 09:06:28 2008 > New Revision: 186076 > URL: http://svn.freebsd.org/changeset/base/186076 > > Log: > Bug fix: %ebx needs to be preserved in the user callchain capture > path. > > Modified: > head/sys/amd64/amd64/exception.S > > Modified: head/sys/amd64/amd64/exception.S > ============================================================================== > --- head/sys/amd64/amd64/exception.S Sun Dec 14 06:40:04 2008 (r186075) > +++ head/sys/amd64/amd64/exception.S Sun Dec 14 09:06:28 2008 (r186076) > @@ -459,9 +459,9 @@ nmi_calltrap: > */ > movq %rsp,%rsi /* source stack pointer */ > movq $TF_SIZE,%rcx > - movq PCPU(RSP0),%rbx > - subq %rcx,%rbx > - movq %rbx,%rdi /* destination stack pointer */ > + movq PCPU(RSP0),%rdx > + subq %rcx,%rdx > + movq %rdx,%rdi /* destination stack pointer */ > > shrq $3,%rcx /* trap frame size in long words */ > cld > @@ -470,7 +470,7 @@ nmi_calltrap: > > movl %ss,%eax > pushq %rax /* tf_ss */ > - pushq %rbx /* tf_rsp (on kernel stack) */ > + pushq %rdx /* tf_rsp (on kernel stack) */ > pushfq /* tf_rflags */ > movl %cs,%eax > pushq %rax /* tf_cs */ Stupid question -- where's the change? All I see are potentially whitespace modifications.. -Garrett