From owner-freebsd-current@FreeBSD.ORG  Sun Feb  3 10:33:03 2013
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 49039DED;
 Sun,  3 Feb 2013 10:33:03 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
 by mx1.freebsd.org (Postfix) with ESMTP id 62577124;
 Sun,  3 Feb 2013 10:33:01 +0000 (UTC)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
 [212.40.38.100])
 by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id MAA07161;
 Sun, 03 Feb 2013 12:33:00 +0200 (EET) (envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
 by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
 id 1U1wsd-0006DZ-NI; Sun, 03 Feb 2013 12:32:59 +0200
Message-ID: <510E3CDB.2070803@FreeBSD.org>
Date: Sun, 03 Feb 2013 12:32:59 +0200
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:17.0) Gecko/20130121 Thunderbird/17.0.2
MIME-Version: 1.0
To: Konstantin Belousov <kostikbel@gmail.com>
Subject: Re: scheduler->swapper, SI_SUB_RUN_SCHEDULER->SI_SUB_LAST
References: <510CFD90.9000304@FreeBSD.org> <20130202145013.GV2522@kib.kiev.ua>
In-Reply-To: <20130202145013.GV2522@kib.kiev.ua>
X-Enigmail-Version: 1.4.6
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: freebsd-hackers@FreeBSD.org, freebsd-current@FreeBSD.org
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 03 Feb 2013 10:33:03 -0000

on 02/02/2013 16:50 Konstantin Belousov said the following:
> On Sat, Feb 02, 2013 at 01:50:40PM +0200, Andriy Gapon wrote:
>>
>> I would like to propose the following mostly cosmetic change:
>> http://people.freebsd.org/~avg/scheduler-swapper.diff
>>
>> This is something that bit me early in my FreeBSD days, so I am kind of obsessed
>> with it.
>> The current naming is confusing/misleading indeed.
>> And magic properties of SI_SUB_RUN_SCHEDULER:SI_ORDER_LAST is a "hidden gem".
> 
> You may remove the Giant unlock from the scheduler()/swapper() as well
> then, doing it before the swapper() call in the mi_startup().
> 
> Note that the wait chain for the idle swapper is still called "sched".

Thank you for the review.  I am fixing both issues.

-- 
Andriy Gapon