From owner-dev-commits-src-all@freebsd.org Tue Sep 14 20:53:29 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BA40C671172; Tue, 14 Sep 2021 20:53:29 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4H8Ftd4qjGz3L8R; Tue, 14 Sep 2021 20:53:29 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-oi1-f176.google.com with SMTP id bd1so1063167oib.5; Tue, 14 Sep 2021 13:53:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=su3faFPazvSp0p9xlGtdC9I1yunW3UbVWIb0oP1yTLI=; b=OPITaAtedDLFhM1elpOBClEXe39nBAYSysgLTVtOCKWJfMhBdJyyqRNAwLnwcUaog0 p1jAO4t+VPHnwefzK26g+8KY4gzzVVcFaHACEe38PU94QD0ZDro+/9CcB4eMN2yOe13E YajnGxVPLFNKm14nJ7b5ddUNO8ZdF3ld3WidNURoE1vHIVY32kCWQnEGGkzX3in0LUT5 LZquChc1K/sgZdwmJ61tnxsslEBUA8X5CHYy5q0phFUIfuEL9xApHJnWaHETnebBBb6V 3u0QMCG/2XUNWv8LBGcVl4uQzJpJ/c06lPsuNLFAzbBSTPYr4Uk0N1zHve3E0Gm/K7qk gSSw== X-Gm-Message-State: AOAM533IJjbscJ30VdFxvb47yIHwzP4REfdSzrbJEKj1hffgEJQfrU4f psz4S9ODcHuDzM9N3aGPNkxd086srSIhmujVLfmC0a6E X-Google-Smtp-Source: ABdhPJxiNWqbu2vPJGuOMonF3aK0FnKDnYKclQqQP1ZGS40JShM66ar9h0GQEHBG4JdermGu/yo6ZfP5+8q7PaGbxZY= X-Received: by 2002:a54:4e94:: with SMTP id c20mr2902901oiy.57.1631652803303; Tue, 14 Sep 2021 13:53:23 -0700 (PDT) MIME-Version: 1.0 References: <202109142046.18EKkfEN043871@gitrepo.freebsd.org> In-Reply-To: <202109142046.18EKkfEN043871@gitrepo.freebsd.org> From: Alan Somers Date: Tue, 14 Sep 2021 14:53:11 -0600 Message-ID: Subject: Re: git: 1ecbc1d8e9d3 - main - cxgbe tom: Don't queue AIO requests on listen sockets. To: John Baldwin Cc: src-committers , "" , dev-commits-src-main@freebsd.org X-Rspamd-Queue-Id: 4H8Ftd4qjGz3L8R X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Sep 2021 20:53:29 -0000 On Tue, Sep 14, 2021 at 2:46 PM John Baldwin wrote: > The branch main has been updated by jhb: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=1ecbc1d8e9d3fbcd8e68fc68f0a32944a12ddb1e > > commit 1ecbc1d8e9d3fbcd8e68fc68f0a32944a12ddb1e > Author: John Baldwin > AuthorDate: 2021-09-14 20:46:14 +0000 > Commit: John Baldwin > CommitDate: 2021-09-14 20:46:14 +0000 > > cxgbe tom: Don't queue AIO requests on listen sockets. > > This is similar to the fixes in 141fe2dceeae. One difference is that > TOE sockets do not change states (listen vs non-listen) once created, > so no lock is needed for SOLISTENING(). > > Sponsored by: Chelsio Communications > I've always wondered: what's the point to using AIO with sockets? Can't everything socket-related be done better with non-blocking read/write and kqueue?