From owner-cvs-src@FreeBSD.ORG Sun Sep 18 19:48:32 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AE22C16A41F; Sun, 18 Sep 2005 19:48:32 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2DF6F43D45; Sun, 18 Sep 2005 19:48:32 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.3/8.13.3) with ESMTP id j8IJj81p010930; Sun, 18 Sep 2005 13:45:08 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Sun, 18 Sep 2005 13:45:18 -0600 (MDT) Message-Id: <20050918.134518.31977329.imp@bsdimp.com> To: nate@root.org From: "M. Warner Losh" In-Reply-To: <432D9F4B.9080902@root.org> References: <200509111928.j8BJSWci066427@repoman.freebsd.org> <70e8236f0509180715406f1f31@mail.gmail.com> <432D9F4B.9080902@root.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Sun, 18 Sep 2005 13:45:09 -0600 (MDT) Cc: cvs-src@freebsd.org, joao.barros@gmail.com, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/pci pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Sep 2005 19:48:32 -0000 In message: <432D9F4B.9080902@root.org> Nate Lawson writes: : Joao Barros wrote: : > On 9/11/05, Warner Losh wrote: : > : >>imp 2005-09-11 19:28:31 UTC : >> : >> FreeBSD src repository : >> : >> Modified files: (Branch: RELENG_6) : >> sys/dev/pci pci.c : >> Log: : >> Change the default of pci_do_powerstate to 0, per request from re@. : >> The number of raid controllers that violate the WHQL seems to be : >> growing in number and not isolated to old versions as previously : >> thought. Though the numbers of these seen in the wild is still : >> relatively small, they hang the system when parts of their devices are : >> powered down. The one area that these parts appear often are in the : >> higher end servers. As such, be conservative about powering down : >> devices that have no driver attached by default. Until a better : >> approach is proven in current, this is the prudent choice. : >> : >> Laptop users wishing the benefits of powering down devices with no : >> drivers will now need to set hw.pci.do_powerstate=1 in their : >> /boot/loader.conf file. Some users will have devices that will : >> prevent this setting (hence the need to make it default 0). : >> : >> Approved by: re@ (scottl) : >> : >> Revision Changes Path : >> 1.292.2.2 +2 -2 src/sys/dev/pci/pci.c : > : > I was reading the Release Notes for 6.0 on : > http://www.freebsd.org/relnotes/6-STABLE/relnotes/i386/article.html : > and noticed: : > : > 2.2.2 Hardware Support : > : > The acpi(4) driver now turns the ACPI and PCI devices off or to a : > lower power state when suspending, and back on again when resuming. : > This behavior can be disabled by setting the debug.acpi.do_powerstate : > and hw.pci.do_powerstate sysctls to 0. : > : > Given this is the same tunable you changed back to 0 by default, does : > that "when resuming" has anything to do with this last commit? If so, : > it could still be mentioned the other way around, allowing people : > wanting to, to enable the tunable :) : : You bring up a different point also, which is that ACPI should probably : be set to match this same default for release. Actually, all that the do_powerstate stuff in pci land does is turn off the devices when no driver is attached. We always turn them back on on resume. Warner