From owner-cvs-all Wed May 22 7:32:46 2002 Delivered-To: cvs-all@freebsd.org Received: from k6.locore.ca (k6.locore.ca [198.96.117.170]) by hub.freebsd.org (Postfix) with ESMTP id 7A86037B401; Wed, 22 May 2002 07:32:37 -0700 (PDT) Received: (from jake@localhost) by k6.locore.ca (8.11.6/8.11.6) id g4MEjr682128; Wed, 22 May 2002 10:45:53 -0400 (EDT) (envelope-from jake) Date: Wed, 22 May 2002 10:45:52 -0400 From: Jake Burkholder To: Bruce Evans Cc: Ruslan Ermilov , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/elf2aout elf2aout.c Message-ID: <20020522104552.F62759@locore.ca> References: <20020520144919.D62759@locore.ca> <20020522211222.X9440-100000@gamplex.bde.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20020522211222.X9440-100000@gamplex.bde.org>; from bde@zeta.org.au on Wed, May 22, 2002 at 09:38:53PM +1000 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Apparently, On Wed, May 22, 2002 at 09:38:53PM +1000, Bruce Evans said words to the effect of; > On Mon, 20 May 2002, Jake Burkholder wrote: > > > Apparently, On Mon, May 20, 2002 at 08:24:31PM +0300, > > Ruslan Ermilov said words to the effect of; > > > > > On Mon, May 20, 2002 at 07:17:39PM +0300, Ruslan Ermilov wrote: > > > > On Mon, May 20, 2002 at 12:15:14PM -0400, Jake Burkholder wrote: > > > > > Apparently, On Mon, May 20, 2002 at 12:56:40AM -0700, > > > > > Ruslan Ermilov said words to the effect of; > > > > > > > > > > > ru 2002/05/20 00:56:40 PDT > > > > > > > > > > > > Modified files: > > > > > > usr.bin/elf2aout elf2aout.c > > > > > > Log: > > > > > > s/u_int/u_int32_t/ > > > > > > > > > > I would have preferred you to not commit this, it does nothing. > > > > > > > > > It makes code more MI, as u_int is not guaranteed to be 32 bit. > > > > This also makes it explicit that we're dealing with the elf32 > > > > here, not elf64. > > > > > > > These would even better be declared using the Elf32_* types. > > > Could you please fix this? > > > > Umm, its an a.out header. u_int{,32_t} is correct. > > Actually, a fixed-width unsigned integer type with the same number of > bits as `unsigned long' on the target machine is correct, since the > type in a target struct exec is `unsigned long' (see ). > `unsigned long' for all targets is inconvenient for cross-compiling > and gratuitously compiler-dependent, but it was almost as good as > possible since it was the largest integer type. `u_int' for all targets > would be just broken since it might be 16 bits. The target machine is actually sparcv8. > > Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message