From owner-freebsd-net@FreeBSD.ORG  Wed Jul 10 22:18:29 2013
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 19C7A8CC
 for <freebsd-net@freebsd.org>; Wed, 10 Jul 2013 22:18:29 +0000 (UTC)
 (envelope-from longwitz@incore.de)
Received: from dss.incore.de (dss.incore.de [195.145.1.138])
 by mx1.freebsd.org (Postfix) with ESMTP id D16681EB4
 for <freebsd-net@freebsd.org>; Wed, 10 Jul 2013 22:18:28 +0000 (UTC)
Received: from inetmail.dmz (inetmail.dmz [10.3.0.3])
 by dss.incore.de (Postfix) with ESMTP id 56C0B5CB1F;
 Thu, 11 Jul 2013 00:18:21 +0200 (CEST)
X-Virus-Scanned: amavisd-new at incore.de
Received: from dss.incore.de ([10.3.0.3])
 by inetmail.dmz (inetmail.dmz [10.3.0.3]) (amavisd-new, port 10024)
 with LMTP id 3s7a5T0LO2LT; Thu, 11 Jul 2013 00:18:20 +0200 (CEST)
Received: from mail.incore (fwintern.dmz [10.0.0.253])
 by dss.incore.de (Postfix) with ESMTP id 975DD5C7CA;
 Thu, 11 Jul 2013 00:18:20 +0200 (CEST)
Received: from bsdmhs.longwitz (unknown [192.168.99.6])
 by mail.incore (Postfix) with ESMTP id 41BAB50881;
 Thu, 11 Jul 2013 00:18:20 +0200 (CEST)
Message-ID: <51DDDDAB.6070100@incore.de>
Date: Thu, 11 Jul 2013 00:18:19 +0200
From: Andreas Longwitz <longwitz@incore.de>
User-Agent: Thunderbird 2.0.0.19 (X11/20090113)
MIME-Version: 1.0
To: pyunyh@gmail.com
Subject: Re: sis(4) flow control
References: <51DC1599.8040805@incore.de>
 <20130710023512.GB2753@michelle.cdnetworks.com>
In-Reply-To: <20130710023512.GB2753@michelle.cdnetworks.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Cc: freebsd-net@freebsd.org
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Jul 2013 22:18:29 -0000

Yonghyeon PYUN wrote:

> Hmm, does the change really make flow-control work?
> I believe flow-control should be negotiated with remote link
> partner so you have to announce flow-control capability to link
> partner. In addition, it seems DP83815/DP83816 does not support
> TX flow-control so it just honors RX pause frames.

Excuse me, the comment in my patch was wrong. Better would be
     /* Enable reception of 802.3x pause frames. */.
My soekris boxes are connected to a slow so called "Ethernet Connect"
line (2 Mbit/s). The line works correct and stable if I respect incoming
RX pause frames from the line. I do not need TX flow-control.

> Try attached patch and let me know how it works.

Thanks for your patch. I will test it on next update of my soekris boxes
with sis interfaces. Because they are all remote far away this will need
some time.

-- 
Andreas Longwitz