Date: Tue, 7 Jul 2015 10:04:41 -0600 From: Adam Weinberger <adamw@adamw.org> To: Kris Moore <kmoore@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r391421 - in head/sysutils: . docker docker/files Message-ID: <4EDFA23E-40C0-4B8E-B6D6-709C9B0B6A34@adamw.org> In-Reply-To: <201507061537.t66FbYeo022971@repo.freebsd.org> References: <201507061537.t66FbYeo022971@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Kris, I hope you don't feel like you're getting picked on for this =
port. But there are a few unusual/non-optimal things in the Makefile:
> +BUILD_DEPENDS=3D ${LOCALBASE}/bin/go:${PORTSDIR}/lang/go \
> + ${LOCALBASE}/bin/bash:${PORTSDIR}/shells/bash \
> + ${LOCALBASE}/bin/git:${PORTSDIR}/devel/git \
> + sqlite3:${PORTSDIR}/databases/sqlite3
> +RUN_DEPENDS=3D ${LOCALBASE}/bin/go:${PORTSDIR}/lang/go \
> + ${LOCALBASE}/bin/bash:${PORTSDIR}/shells/bash \
> + sqlite3:${PORTSDIR}/databases/sqlite3
All of those programs are in ${PATH}. There is no need for the =
${LOCALBASE}/bin/ stuff.
Also, git is not used at any point and that dependency can be safely =
removed, especially given that you already pass DOCKER_GITCOMMIT in env.
> + ${INSTALL} ${WRKSRC}/bundles/latest/binary/docker =
${STAGEDIR}${PREFIX}/bin/
You want ${INSTALL_PROGRAM} here, not bare ${INSTALL}.
# Adam
--=20
Adam Weinberger
adamw@adamw.org
http://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4EDFA23E-40C0-4B8E-B6D6-709C9B0B6A34>