From owner-freebsd-multimedia@FreeBSD.ORG Tue Jan 11 21:09:17 2011 Return-Path: Delivered-To: freebsd-multimedia@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E84DC106567A; Tue, 11 Jan 2011 21:09:17 +0000 (UTC) (envelope-from fbsd@opal.com) Received: from mho-01-ewr.mailhop.org (mho-01-ewr.mailhop.org [204.13.248.71]) by mx1.freebsd.org (Postfix) with ESMTP id A8F698FC12; Tue, 11 Jan 2011 21:09:17 +0000 (UTC) Received: from pool-141-154-232-8.bos.east.verizon.net ([141.154.232.8] helo=homobox.opal.com) by mho-01-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1PclSu-000LFs-JO; Tue, 11 Jan 2011 21:09:17 +0000 Received: from opal.com (localhost [IPv6:::1]) (authenticated bits=0) by homobox.opal.com (8.14.4/8.14.4) with ESMTP id p0BL9B4x066116 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 11 Jan 2011 16:09:11 -0500 (EST) (envelope-from fbsd@opal.com) Received: from shibato.opal.com ([2001:5c0:1100:f103:221:63ff:fe5a:c9a7] helo=shibato.opal.com) with IPv6:587 by opal.com; 11 Jan 2011 16:09:11 -0500 X-Mail-Handler: MailHop Outbound by DynDNS X-Originating-IP: 141.154.232.8 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/mailhop/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX19qrDuCUZ3unZQdnEj8wEjf Date: Tue, 11 Jan 2011 16:09:07 -0500 From: "J.R. Oldroyd" To: Andrew Gallatin Message-ID: <20110111160907.454c74d7@shibato.opal.com> In-Reply-To: References: <20091204223126.00005392@unknown> <201001081650.14189.hselasky@c2i.net> <20100108114130.1cfe88c5@shibato.opal.com> <201101110947.46399.hselasky@c2i.net> <20110111092609.7bf82016@shibato.opal.com> <20110111183937.GA36761@triton8.kn-bremen.de> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.20.1; amd64-portbld-freebsd8.1) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/W4R7V1QbhiR=lnfRH/uvidz"; protocol="application/pgp-signature" Cc: freebsd-multimedia@freebsd.org, emulation@freebsd.org, freebsd-emulation@freebsd.org, Juergen Lock , Alexander Leidinger Subject: Re: FYI: v4l-linuxulator support in FreeBSD-current now X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jan 2011 21:09:18 -0000 --Sig_/W4R7V1QbhiR=lnfRH/uvidz Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, 11 Jan 2011 15:17:59 -0500, Andrew Gallatin wr= ote: > > On Tue, Jan 11, 2011 at 1:39 PM, Juergen Lock wr= ote: >=20 > > =C2=A0And FE_[GS]ET_PROPERTY I think are part of the `new' dvb api that > > was introduced when adding support for dvb-s2, which would also > > explain why the naive patch appeared to work: =C2=A0whatever app(s) were > > used to test it probably were just still using the `old' dvb api. > > (Well, or the tests were only done on i386. :) >=20 > Test was done with just azap, dvbtraffic, and test_dvr on amd64.. >=20 > Drew At issue is not if the simple patch works for a few apps. At issue is whether or not FreeBSD should code defensively to protect against possible problems in the future. When I did the V4L shim, my initial test app (Skype) also worked without much of the structure conversion code. I was asked to write additional structure conversion code anyway, because it is the correct way to handle such data when the field sizes are not defined. The good news is that the conversion code is not complex. One copy in function and one copy out function that hande those data types whose length may vary is needed for each such structure. The bad news is, as I understand it, that DVB is tied closely to V4L2, so it may be necessary to implement a complete set of conversion code for all V4L2 functions, too. Is this the case? I'm not sure. On the other hand, if it is working acceptably now, we could just add the simpler patch and punt any conversion code until/if something is found to not work properly, later. -jr --Sig_/W4R7V1QbhiR=lnfRH/uvidz Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEUEARECAAYFAk0sxvMACgkQls33urr0k4lJgQCXTELX/LtEOyoEn15raj0Oc9dw 5gCfSfykYJ0u0MSNq3H0XFxAKTkqxqI= =lEEA -----END PGP SIGNATURE----- --Sig_/W4R7V1QbhiR=lnfRH/uvidz--