Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 17 Jul 2023 15:20:16 GMT
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: af20d58ef1e2 - main - bhyve: Remove an unneeded vm_get_register() call in main()
Message-ID:  <202307171520.36HFKGud038340@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by markj:

URL: https://cgit.FreeBSD.org/src/commit/?id=af20d58ef1e250f1b207a80834445e39b06fdc48

commit af20d58ef1e250f1b207a80834445e39b06fdc48
Author:     Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2023-07-05 20:59:20 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2023-07-17 15:15:54 +0000

    bhyve: Remove an unneeded vm_get_register() call in main()
    
    At one point the RIP value was passed to fbsdrun_addcpu(), but this is
    no longer the case.  No functional change intended.
    
    Reviewed by:    jhb, corvink
    Sponsored by:   Innovate UK
    MFC after:      1 week
    Differential Revision:  https://reviews.freebsd.org/D40988
---
 usr.sbin/bhyve/bhyverun.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/usr.sbin/bhyve/bhyverun.c b/usr.sbin/bhyve/bhyverun.c
index 2a2a0f028d9d..9fedab646002 100644
--- a/usr.sbin/bhyve/bhyverun.c
+++ b/usr.sbin/bhyve/bhyverun.c
@@ -1218,7 +1218,6 @@ main(int argc, char *argv[])
 	struct vcpu *bsp;
 	struct vmctx *ctx;
 	struct qemu_fwcfg_item *e820_fwcfg_item;
-	uint64_t rip;
 	size_t memsize;
 	const char *optstr, *value, *vmname;
 #ifdef BHYVE_SNAPSHOT
@@ -1539,9 +1538,6 @@ main(int argc, char *argv[])
 	}
 #endif
 
-	error = vm_get_register(bsp, VM_REG_GUEST_RIP, &rip);
-	assert(error == 0);
-
 	/*
 	 * build the guest tables, MP etc.
 	 */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202307171520.36HFKGud038340>