Date: Wed, 26 Feb 2025 15:55:34 -0800 From: Gleb Smirnoff <glebius@freebsd.org> To: "Bjoern A. Zeeb" <bz@freebsd.org> Cc: Michael Tuexen <tuexen@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 0e58542fd246 - main - tcp: remove unused field from struct tcpcb Message-ID: <Z7-p9krDX93KSnsz@cell.glebi.us> In-Reply-To: <r6pqp489-s4oq-0p8q-6r68-3931pss41s33@SerrOFQ.bet> References: <202502252048.51PKm4YX061305@gitrepo.freebsd.org> <r6pqp489-s4oq-0p8q-6r68-3931pss41s33@SerrOFQ.bet>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Feb 26, 2025 at 02:23:46AM +0000, Bjoern A. Zeeb wrote:
B> > --- a/sys/netinet/tcp_var.h
B> > +++ b/sys/netinet/tcp_var.h
B> > @@ -452,7 +452,6 @@ struct tcpcb {
B> > tcp_seq gput_seq; /* Outbound measurement seq */
B> > tcp_seq gput_ack; /* Inbound measurement ack */
B> > int32_t t_stats_gput_prev; /* XXXLAS: Prev gput measurement */
B> > - uint32_t t_maxpeakrate; /* max peak rate set by user, bytes/s */
B>
B> Is the tcpcb no longer KBI relevant these days?
B> In the old days we'd simply make this a spare and not move all offsets
B> below around.
In the old days tcpcb was visible to userland, that's why there was
the spare habit.
On FreeBSD CURRENT we don't provide KBI stability between core network
stack and advanced TCP stacks as loadable modules, neither NIC driver
modules that meddle with TCP.
--
Gleb Smirnoff
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Z7-p9krDX93KSnsz>