From owner-svn-src-head@freebsd.org Sat Nov 30 23:25:01 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 997821BBF94; Sat, 30 Nov 2019 23:25:01 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47QSCJ397dz4fd0; Sat, 30 Nov 2019 23:25:00 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id xAUNOqG9041878 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sun, 1 Dec 2019 01:24:55 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua xAUNOqG9041878 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id xAUNOqDS041877; Sun, 1 Dec 2019 01:24:52 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 1 Dec 2019 01:24:52 +0200 From: Konstantin Belousov To: Mateusz Guzik Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r355227 - head/sys/fs/tmpfs Message-ID: <20191130232452.GC10580@kib.kiev.ua> References: <201911301641.xAUGfmMt029299@repo.freebsd.org> <20191130230725.GB10580@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tom.home X-Rspamd-Queue-Id: 47QSCJ397dz4fd0 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none); spf=softfail (mx1.freebsd.org: 2001:470:d5e7:1::1 is neither permitted nor denied by domain of kostikbel@gmail.com) smtp.mailfrom=kostikbel@gmail.com X-Spamd-Result: default: False [-2.00 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; DMARC_POLICY_SOFTFAIL(0.10)[gmail.com : No valid SPF, No valid DKIM,none]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FREEMAIL_FROM(0.00)[gmail.com]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all]; IP_SCORE_FREEMAIL(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; IP_SCORE(0.00)[ip: (-2.70), ipnet: 2001:470::/32(-4.64), asn: 6939(-3.52), country: US(-0.05)]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Nov 2019 23:25:01 -0000 On Sun, Dec 01, 2019 at 12:15:06AM +0100, Mateusz Guzik wrote: > On 12/1/19, Konstantin Belousov wrote: > > On Sat, Nov 30, 2019 at 04:41:48PM +0000, Mateusz Guzik wrote: > >> Author: mjg > >> Date: Sat Nov 30 16:41:47 2019 > >> New Revision: 355227 > >> URL: https://svnweb.freebsd.org/changeset/base/355227 > >> > >> Log: > >> tmpfs: add fast path to tmpfs_access for common case lookup > >> > >> VEXEC consists of vast majority of all calls and almost all targets > >> have > >> at least 0111. > > On what load VEXEC is the dominant access check ? > > > > Note this is called for every directory to be traversed dooring lookup, > so for instance looking up "foo/bar/baz" performs 2 VEXEC checks. So it is for directory components traversal during lookup. Does it make sense to add something similar at the start of ufs_accessx() when neither kind of ACLs is enabled for mp ? > > Sample result from buildkernel. 64 is VEXEC. > > dtrace -n 'fbt::tmpfs_access:entry { @[args[0]->a_accmode, ((struct > tmpfs_node *)args[0]->a_vp->v_data)->tn_mode & 0111] = count(); }' > dtrace: description 'fbt::tmpfs_access:entry ' matched 1 probe > > > 384 73 1 > 16512 0 2 > 128 0 68 > 384 0 877 > 4096 0 1049 > 320 73 5965 > 4096 73 32471 > 128 73 145115 > 256 73 160569 > 256 0 999827 > 64 73 32320731 > > >> > >> Modified: > >> head/sys/fs/tmpfs/tmpfs_vnops.c > >> > >> Modified: head/sys/fs/tmpfs/tmpfs_vnops.c > >> ============================================================================== > >> --- head/sys/fs/tmpfs/tmpfs_vnops.c Sat Nov 30 16:40:16 2019 (r355226) > >> +++ head/sys/fs/tmpfs/tmpfs_vnops.c Sat Nov 30 16:41:47 2019 (r355227) > >> @@ -331,6 +331,12 @@ tmpfs_access(struct vop_access_args *v) > >> > >> node = VP_TO_TMPFS_NODE(vp); > >> > >> + /* > >> + * Common case path lookup. > >> + */ > >> + if (__predict_true(accmode == VEXEC && (node->tn_mode & 0111) == 0111)) > > The 0111 must be spelled as (S_IXUSR | S_IXGRP | S_IXOTH). > > > > Ok. > > >> + return (0); > >> + > >> switch (vp->v_type) { > >> case VDIR: > >> /* FALLTHROUGH */ > > > > > -- > Mateusz Guzik