Date: Thu, 3 Mar 2016 13:12:05 +0100 From: Hans Petter Selasky <hps@selasky.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r296320 - in head/sys: kern sys Message-ID: <56D82A15.3050804@selasky.org> In-Reply-To: <20160303115823.GQ67250@kib.kiev.ua> References: <201603021846.u22IkHWM010861@repo.freebsd.org> <56D81918.6020403@selasky.org> <20160303112716.GO67250@kib.kiev.ua> <56D821A7.2020105@selasky.org> <20160303115823.GQ67250@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On 03/03/16 12:58, Konstantin Belousov wrote: >> > >> >Yes, your change is compatible if you compile the code, but not binary >> >compatible. See the following macros, and how they use _callout_stop_safe(): > My change is binary compatible. > >> > >> >#define callout_stop(c) _callout_stop_safe(c, 0, NULL) >> >#define callout_async_drain(c, d) \ >> > _callout_stop_safe(c, 0, d) >> > >> >Because callout_stop(c) is a macro, you've now change the API for >> >callout_stop() aswell. This is what I think will break binary >> >compatibility in 10.x. > How my commit changes anything for either callout_stop(), or for > callout_async_drain(), or for callout_drain() ? > Hi, It looked like you added another argument to _callout_stop_safe(). After a closer look I see the patch is binary compatible. --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56D82A15.3050804>