From nobody Sat Jun 6 03:29:09 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gXP116Lhrz6h3fy for ; Sat, 06 Jun 2026 03:29:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gXP1141YTz45GV for ; Sat, 06 Jun 2026 03:29:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780716549; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xHtEM8FuxyCiAfaKkiK50229qQJ+WLaaYO9WzX7HcL8=; b=qbLy3xxIi91qBr+12wT3+cYTdJ1XJwTBBVTQUbxZAxlo1zSdj+IuiQp5SuqGP3IMGGT7dN Ahvgb+varp7phxQU6Op0U3AiyyNlMg4GLMQoGSPDFxhmyZoPp1kmKBP07knDKYY6qmRi2C PA4GhHMQa25l6Pc4SN4lO9LQgHbaDQaRusw+JOhsO9cprAyM+zlEycjVc4WCWySB3aasqc mEpX1G0E68Yv9+Dbj70kIThBcoA4XlrOEYzsyH3/p0YcBd6IsIwso4Wk9HnDTOZwtYXzYt 2m33D2dH3uthVgiiFP5wtPYwTRM/1UBqlS/jfWomkwQCRMfxeDKWDqIJZt+MRQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1780716549; a=rsa-sha256; cv=none; b=n9F2lgMVU9Hi4p76weO7TAn05trCAlC1w4a3d+KTcB1VszSsRcsO7YcaCrHYII67QP3wAK qoBVi4Ga/b3xQsFlQ+gozOL/zUeSWUqJQrv7QHGDtrPEpLPXKkuxYMyeQYWNPwsmUdiDXE rYVXDsxzx3hbX6HUCJvwCXWjmEv0B9k1drtu0k1ktiysTrXEJHPSLGpvtIuUhW7xjaPciB W8LL3fuXR64D9ToHacoMfObPWPVbERVlJFBac43GEzF8Rk0fJVumeB+ExbsNohgxqYF0yA GhbtbSuvkL6k88NFiTW3350JEXaVF2+Zb0BP7Mkt2f8XXdss2vx4Mppupx7f4A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780716549; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xHtEM8FuxyCiAfaKkiK50229qQJ+WLaaYO9WzX7HcL8=; b=rOmN1JJ9XowXR0uxdfyE8NHRULqvNBut9Rt48Bpf5d6fPrE9hCVS1Dpxhe/ytE28ASg/d5 Jns1/Frbp/iXW/QF0TD34L3Py1kWHN2hH7ZhsJY2HtMt+DMrDYAqWp38P1ZSoiImT3/L5c Oehxf460WutcjMrU/3ITX0J0GUatRr0quDeWmBHK+hGSu3LE1u3fmj/OBsSq839dFpVCug VnLPZoLRKhwbG+szGpF5pdINamAQlNf8sEtDn1lIniuOw6D2NAOKz4H7xB4NBB5WFKhW4p FQbN9kmFRljAmg07PnQlQD97Yski8kor8x8oMLTjZgeKq/hoNMhRnEiy/iWN1g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gXP113c69zxss for ; Sat, 06 Jun 2026 03:29:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 45c53 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 06 Jun 2026 03:29:09 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 5d0ebfe1d978 - main - renameat(2): when retrying, check for pending signals List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5d0ebfe1d97801518755c7025f57ba7d5bf1c8db Auto-Submitted: auto-generated Date: Sat, 06 Jun 2026 03:29:09 +0000 Message-Id: <6a239405.45c53.5dc6dad9@gitrepo.freebsd.org> The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=5d0ebfe1d97801518755c7025f57ba7d5bf1c8db commit 5d0ebfe1d97801518755c7025f57ba7d5bf1c8db Author: Konstantin Belousov AuthorDate: 2026-06-04 17:53:26 +0000 Commit: Konstantin Belousov CommitDate: 2026-06-06 03:28:28 +0000 renameat(2): when retrying, check for pending signals The vn_start_write() call there is already interruptible. Check for user signals before restarting due to ERELOOKUP, or after failed vn_start_write(). Note that vn_start_write(V_XSLEEP | V_PCATCH) does not check for signals if not sleeping. PR: 295826 Reviewed by: markj Tested by: pho Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D57453 --- sys/kern/vfs_syscalls.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/sys/kern/vfs_syscalls.c b/sys/kern/vfs_syscalls.c index 0c4eeb584d41..71d37e08c65b 100644 --- a/sys/kern/vfs_syscalls.c +++ b/sys/kern/vfs_syscalls.c @@ -3855,6 +3855,9 @@ again1: vfs_rel(tmp); tmp = NULL; } + error = sig_intr(); + if (error != 0) + return (error); error = vn_start_write(NULL, &mp, V_XSLEEP | V_PCATCH); if (error != 0) return (error); @@ -3937,8 +3940,11 @@ out: out1: if (error == ERESTART) return (0); - if (error == ERELOOKUP) - goto again; + if (error == ERELOOKUP) { + error = sig_intr(); + if (error == 0) + goto again; + } return (error); }