From owner-cvs-all  Wed Sep  5  9:25:19 2001
Delivered-To: cvs-all@freebsd.org
Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42])
	by hub.freebsd.org (Postfix) with ESMTP
	id C122137B403; Wed,  5 Sep 2001 09:25:14 -0700 (PDT)
Received: (from ache@localhost)
	by nagual.pp.ru (8.11.6/8.11.6) id f85GP6551963;
	Wed, 5 Sep 2001 20:25:06 +0400 (MSD)
	(envelope-from ache)
Date: Wed, 5 Sep 2001 20:25:04 +0400
From: "Andrey A. Chernov" <ache@nagual.pp.ru>
To: Dag-Erling Smorgrav <des@ofug.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/lib/libfetch file.c
Message-ID: <20010905202504.A51847@nagual.pp.ru>
References: <200109051222.f85CMS414529@freefall.freebsd.org> <20010905181734.B50064@nagual.pp.ru> <xzpbskpsmas.fsf@flood.ping.uio.no>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <xzpbskpsmas.fsf@flood.ping.uio.no>
User-Agent: Mutt/1.3.21i
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Wed, Sep 05, 2001 at 17:13:31 +0200, Dag-Erling Smorgrav wrote:
> "Andrey A. Chernov" <ache@nagual.pp.ru> writes:
> > >   Use fseeko() instead of fseek() (u->offset is already an off_t), and mark
> > >   some function arguments as unused.
> > Please don't forget to change lib/libfetch that way too.
> 
> Please don't forget to make sense :)

> If you mean usr.bin/fetch/fetch.c, the fseek() there is redundant, and

I mean lib/libfetch/file.c

Please remember that fseek() not works for >2GB offsets.

-- 
Andrey A. Chernov
http://ache.pp.ru/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message