From owner-freebsd-current  Sat Dec 14 10:57:25 2002
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id EEF2637B401
	for <freebsd-current@FreeBSD.ORG>; Sat, 14 Dec 2002 10:57:23 -0800 (PST)
Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9FA1C43EC2
	for <freebsd-current@FreeBSD.ORG>; Sat, 14 Dec 2002 10:57:23 -0800 (PST)
	(envelope-from dillon@apollo.backplane.com)
Received: from apollo.backplane.com (localhost [127.0.0.1])
	by apollo.backplane.com (8.12.5/8.12.5) with ESMTP id gBEIvKOM006568;
	Sat, 14 Dec 2002 10:57:20 -0800 (PST)
	(envelope-from dillon@apollo.backplane.com)
Received: (from dillon@localhost)
	by apollo.backplane.com (8.12.5/8.12.5/Submit) id gBEIvKBv006567;
	Sat, 14 Dec 2002 10:57:20 -0800 (PST)
	(envelope-from dillon)
Date: Sat, 14 Dec 2002 10:57:20 -0800 (PST)
From: Matthew Dillon <dillon@apollo.backplane.com>
Message-Id: <200212141857.gBEIvKBv006567@apollo.backplane.com>
To: Archie Cobbs <archie@dellroad.org>
Cc: freebsd-current@FreeBSD.ORG, Peter Edwards <pmedwards@eircom.net>
Subject: Re: Request for review: kern/45994
References:  <200212141803.gBEI3VwN023464@arch20m.dellroad.org>
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

    Well, there are two patches in that PR.  I was not able to unpack
    the second mime-encoded diff that implements the NOCORE method, which
    is the one I think we should use.  The described methodology is sound,
    though.  If someone could email the diff to me I will give it a more
    complete lookover.

						-Matt

:Could some knowlegable folks review the patch in kern/45994?
:
:    http://www.freebsd.org/cgi/query-pr.cgi?pr=45994
:
:Note: I'm talking about the second patch, not the first one.
:In the PR the second patch is base64 encoded and not readable.
:Here is a decoded version:
:
:    http://www.dellroad.org/dropbox/coredump.diff
:
:I'm not expert enough in this area to review it alone, but would
:be happy to commit it if other agree it's suitable.
:
:Thanks,
:-Archie
:
:__________________________________________________________________________
:Archie Cobbs     *     Packet Design     *     http://www.packetdesign.com

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message