From owner-svn-src-head@FreeBSD.ORG  Fri Jan 29 14:23:47 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7CB1E106566C;
	Fri, 29 Jan 2010 14:23:47 +0000 (UTC)
	(envelope-from brde@optusnet.com.au)
Received: from mail09.syd.optusnet.com.au (mail09.syd.optusnet.com.au
	[211.29.132.190])
	by mx1.freebsd.org (Postfix) with ESMTP id EF3F08FC13;
	Fri, 29 Jan 2010 14:23:46 +0000 (UTC)
Received: from c122-106-174-165.carlnfd1.nsw.optusnet.com.au
	(c122-106-174-165.carlnfd1.nsw.optusnet.com.au [122.106.174.165])
	by mail09.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id
	o0TENhv0014417
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Sat, 30 Jan 2010 01:23:44 +1100
Date: Sat, 30 Jan 2010 01:23:43 +1100 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@delplex.bde.org
To: Randall Stewart <rrs@FreeBSD.org>
In-Reply-To: <201001290403.o0T43avo045817@svn.freebsd.org>
Message-ID: <20100130011335.R77171@delplex.bde.org>
References: <201001290403.o0T43avo045817@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r203149 - head/sys/mips/rmi
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Jan 2010 14:23:47 -0000

On Fri, 29 Jan 2010, Randall Stewart wrote:

> Log:
>  Move ID up into comment block.. per bsdimp

Any chance of fixing the ~10 other style bugs visible in this patch?  There
are 6 new ones in this commit alone:

> Modified: head/sys/mips/rmi/pic.h
> ==============================================================================
> --- head/sys/mips/rmi/pic.h	Fri Jan 29 03:35:01 2010	(r203148)
> +++ head/sys/mips/rmi/pic.h	Fri Jan 29 04:03:36 2010	(r203149)
> @@ -25,14 +25,15 @@
>  * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
>  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
>  * SUCH DAMAGE.
> + * __FBSDID("$FreeBSD$");

1. Missing blank line before $FreeBSD$.
2. Using the __FBSDID() macro in a comment is nonsense.
3. Insertion sort error.  $FreeBSD$ goes last in the copyright comment.

>  *
>  * RMI_BSD */

4. Block comments are not formatted like this in KNF.

> #ifndef _RMI_PIC_H_
> #define _RMI_PIC_H_

5. Space instead of tab after #define.
6. Missing blank line before whatever follws the idempotency ifndef/def.

> #include <sys/cdefs.h>
> -/*
> -__FBSDID("$FreeBSD$");
> -*/
> +

7. Extra blank line.

> +

8. Extra blank line.

> +

9. Extra blank line.

>
> extern int rmi_spin_mutex_safe;

10. KNF would indent this using a tab or two.

>
>

The 6 new style bugs are 1-3 and 7-9.

Bruce